Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User defined Hotkeys like a VIM #212

Closed
mc-butler opened this issue Jan 26, 2009 · 78 comments
Closed

User defined Hotkeys like a VIM #212

mc-butler opened this issue Jan 26, 2009 · 78 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.3 Reproducible in version 4.7.3
Milestone
4.8.23

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/212
Reporter angel_il (@ilia-maslakov)
Mentions egmont (@egmontkob), xaoxx@…-online.de
Keywords hotkeys, shortcuts

I've started with rework hotkeys engine.
Target: do this like in a VIM :), with user define hotkeys.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 26, 2009 at 11:38 UTC (comment 1)

  • Owner set to angel_il
  • Status changed from new to assigned

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Feb 5, 2009 at 8:10 UTC

@mc-butler
Copy link
Author

Changed by winnie (@winnieXY) on Feb 9, 2009 at 7:24 UTC

  • Blocking set to #195

(In #195) Please have a look on #212. This is about configurable shortcuts in general.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Feb 13, 2009 at 10:10 UTC

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jun 14, 2009 at 22:40 UTC

(In #21) Double for #195. Also blocked by #212.

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jun 19, 2009 at 7:19 UTC

(In #21) I checked it in my environment.

All work in mc builded with ncursesw, so it's slang bug.

Please, write bugreport to slang developers or your distro maintainers.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 2, 2009 at 5:10 UTC (comment 5)

  • Version changed from 4.6.1 to master
  • Severity set to no branch
  • Milestone changed from 4.7 to 4.7.0-pre2

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 18, 2009 at 21:12 UTC (comment 6)

branch: 212_redefine_hotkeys

for test only

for redefine hotkeys
put in

/usr/share/mc/mc.keymap

[editor]
XStore = ctrl g
XPaste = ctrl v
XCut = ctrl x
Delete-Line = ctrl y

[main]
FindCmd = alt f7
ViewOtherCmd = ctrl o

[panel]
PanelStartSearch = ctrl s
PanelMoveDown = down
PanelMoveUp = up
PanelMoveLeft = left
PanelMoveRight = right
PanelPrevPage = pgup
PanelNextPage = pgdn
PanelDoEnter = enter

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 19, 2009 at 16:32 UTC (comment 7)

  • Severity changed from no branch to on review

changeset: [a4adb6a08adef20c2734ea64c0e35783576e20a7]

Wow it worked!!! :)
Welcome review :)

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jul 20, 2009 at 9:41 UTC (comment 6.8)

Replying to angel_il:

branch: 212_redefine_hotkeys

for test only

for redefine hotkeys
put in

/usr/share/mc/mc.keymap

path should be etc/mc/mc.keymap

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jul 20, 2009 at 9:54 UTC (comment 7.9)

  • Severity changed from on review to on rework

Replying to angel_il:

changeset: [a4adb6a08adef20c2734ea64c0e35783576e20a7]

Wow it worked!!! :)
Welcome review :)

Yes. Good work, it's work for me too!

But most of users/testers want working keybindings.

I think we should not break current keybindings and
default mc.keymap (at least as example, if without
mc.keymap we has default bindings, but it seems not)
should be also added in context of this ticket.

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jul 20, 2009 at 10:12 UTC (comment 8.10)

Replying to iNode:

path should be etc/mc/mc.keymap

ok, mc search it in the order ~/.mc, /etc/mc/, $PREFIX/share/mc,
and I has some mc.keymap. So, angel_il, you are right.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 19, 2009 at 6:44 UTC (comment 11)

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 3, 2009 at 10:57 UTC (comment 12)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 3, 2009 at 10:57 UTC (comment 13)

@mc-butler
Copy link
Author

Changed by ierton (@ierton) on Sep 12, 2009 at 15:09 UTC

allows user to type binded chars in quicksearch mode

@mc-butler
Copy link
Author

Changed by ierton (@ierton) on Sep 12, 2009 at 15:11 UTC (comment 14)

Hi! i am searching for a way to add vim-bindings to mc. i've made some testing of your branch with profile like this:

[panel]
PanelStartSearch=/
PanelMoveDown=j
PanelMoveUp=k
PanelMoveLeft=h
PanelMoveRight=l

and here is the problem:
in qick-search mode (when i type '/') it is impossible to type binded letters (in my case - 'j' 'k' 'h' 'l'). I've attached patch to solve the problem. Check it please! Thank you.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 17, 2009 at 13:33 UTC (comment 15)

  • Severity changed from on rework to on review

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Sep 18, 2009 at 7:47 UTC (comment 16)

Please don't forget to provide link to branch on review.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 21, 2009 at 12:08 UTC

(In #1390) Just await for complete of #212

I hope, this help to you.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 22, 2009 at 8:03 UTC

(In #397) > It's a semi-solution. In addition to mouse, the shortcut should be provided.

In this case this branch wil continue to develop after megre #212 into master.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 24, 2009 at 6:28 UTC (comment 19)

  • Description edited
  • Summary changed from User defined Hotkeys like a FAR to User defined Hotkeys like a VIM

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 24, 2009 at 14:55 UTC (comment 20)

  • Severity changed from on review to on rework

in 212_redefine_hotkeys branch I added some commits for restore default hotkeys:

  • [64b80af536d1deb192e4654d3c5d37d4e7299c8b]
  • [1585244b09e19c5ddfcc0cc2b3fbf9b2925919e1]

Newly added hotkeys don't work. :(

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 29, 2009 at 10:55 UTC (comment 21)

  • Severity changed from on rework to on review

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 29, 2009 at 10:57 UTC (comment 22)

  • Votes set to slavazanko

Looks good.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 29, 2009 at 11:15 UTC (comment 23)

changeset: [10fd866]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 29, 2009 at 16:59 UTC (comment 24)

  • Votes changed from slavazanko to slavazanko andrew_b
  • Severity changed from on review to approved
  • Keywords changed from hotkeys to hotkeys, shortcuts

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 29, 2009 at 17:46 UTC (comment 25)

  • Resolution set to fixed
  • Severity changed from approved to merged
  • Votes changed from slavazanko andrew_b to commited-master
  • Status changed from assigned to testing

Fixed: [10fd866]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 29, 2009 at 17:46 UTC (comment 26)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 29, 2009 at 18:36 UTC

(In #1390) angel_il: Need to give mire info :)

To ticketstarter: now feel to free change ${prefix}/etc/mc/mc.keymap file.
For example, like this:

[panel]
...
PanelSetPanelEncoding = ctrl-u

instread of

PanelSetPanelEncoding = ctrl-t

Enjoy. :)

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 6, 2010 at 19:25 UTC (comment 52)

212_dialog_hardcoded_hotkeys (forced update)
changeset: [e9f30aebaee9b35ebc0e4aa8f71e980031c11351]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 7, 2010 at 8:38 UTC (comment 53)

  • Votes changed from andrew_b to andrew_b slavazanko
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 7, 2010 at 12:18 UTC (comment 54)

  • Severity changed from approved to merged
  • Votes changed from andrew_b slavazanko to committed-master
  • Status changed from reopened to closed
  • Resolution set to fixed

fixed: [993bb84]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 12, 2010 at 9:01 UTC (comment 55)

  • Milestone changed from 4.7.2 to 4.7
  • Resolution fixed deleted
  • Votes committed-master deleted
  • Status changed from closed to reopened
  • Version changed from 4.7.1 to 4.7.3
  • Severity changed from merged to no branch

Created 212_listbox_hotkeys branch for implementation of WListbox keybindings.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 12, 2010 at 10:51 UTC (comment 56)

  • Severity changed from no branch to on review

Initial [7a9920c5c1ed743acf67ba91279b9066bde40621]

Please review and vote.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Aug 17, 2010 at 12:44 UTC (comment 57)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 1, 2010 at 11:02 UTC (comment 58)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 1, 2010 at 11:10 UTC (comment 59)

  • Resolution set to fixed
  • Votes changed from slavazanko angel_il to committed-master
  • Status changed from reopened to closed
  • Severity changed from approved to merged

Merged to master.
[a1dce46]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 1, 2010 at 11:19 UTC (comment 60)

  • Severity changed from merged to on review
  • Milestone changed from 4.7 to 4.7.4
  • Votes committed-master deleted
  • Status changed from closed to reopened
  • Resolution fixed deleted

Some hardcoded keys are still used in viewer and in interactive help engine. The 212_viewer_help_hardcoded_keys branch replaces hardcoded keys in these units with keybindings.

212_viewer_help_hardcoded_keys branch. Parent branch is master.
Initial [6b4914b]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 2, 2010 at 9:11 UTC (comment 61)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 3, 2010 at 8:25 UTC (comment 62)

  • Severity changed from on review to approved
  • Votes changed from angel_il to angel_il slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 3, 2010 at 10:53 UTC (comment 63)

  • Severity changed from approved to merged
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Votes changed from angel_il slavazanko to commited-master

Merged to master.
[9f5b88e]

git log --pretty=oneline a1dce46..9f5b88e

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 30, 2019 at 8:28 UTC (comment 64)

  • Status changed from closed to reopened
  • Milestone changed from 4.7.4 to 4.8.23
  • Branch state set to no branch
  • Resolution fixed deleted

The keybind for menu is implemented!

Branch:212_menu_keybind
Initial [ad842d0c6b36adcfdf7107f0ac507cddad289342]

Please review.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 30, 2019 at 8:28 UTC (comment 65)

  • Votes commited-master deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 30, 2019 at 8:29 UTC (comment 66)

  • Branch state changed from no branch to on review

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 9, 2019 at 9:04 UTC (comment 67)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 9, 2019 at 9:05 UTC (comment 68)

  • Status changed from reopened to closed
  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master

Merged to master: [934a2d9].

git log --pretty=oneline 71c0f7640..934a2d931

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 9, 2019 at 9:06 UTC (comment 69)

  • Branch state changed from approved to merged

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on Jun 17, 2019 at 21:12 UTC (comment 70)

  • Cc set to egmont

Unfortunately these changes broke the hotkeys in the F9 menu.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 18, 2019 at 6:32 UTC (comment 70.71)

Replying to egmont:

Unfortunately these changes broke the hotkeys in the F9 menu.

Fixed in [7eaa51c].

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 24, 2019 at 10:06 UTC (comment 72)

  • Cc changed from egmont to egmont, xaoxx@…-online.de
  • Votes committed-master deleted
  • Branch state changed from merged to no branch
  • Status changed from closed to reopened
  • Version changed from 4.7.3 to 4.8.23
  • Resolution fixed deleted
  • Milestone changed from 4.8.23 to 4.8.24

In the pulldown menues the <enter> key doesn't work as expected. Menu
items can only be accessed with the letter keys. Instead, enter be-
haves exactly like down-arrow. This is valid for mc and mcedit.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 24, 2019 at 10:32 UTC (comment 73)

Currently I'm using recent mc and menu works fine for me.
I cannot reproduce the described behaviour.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 23, 2019 at 11:26 UTC (comment 74)

  • Votes set to committed-master
  • Milestone changed from 4.8.24 to 4.8.23
  • Status changed from reopened to closed
  • Resolution set to fixed
  • Version changed from 4.8.23 to 4.7.3
  • Branch state changed from no branch to merged

See #4006.

Previous ticket properties restored.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 17, 2020 at 15:55 UTC (comment 75)

Key bindings for radiobuttons: [946e8d4].

This was referenced Feb 21, 2025
Closed
Closed
@mc-butler mc-butler marked this as a duplicate of #1509 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.3 Reproducible in version 4.7.3
Milestone
4.8.23
Development

No branches or pull requests
2 participants
@aborodin @mc-butler