[PATCH] [Syntax] UPDATED: file extension for "sh"

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2127
Reporter	zaytsev (@zyv)

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502196

From: Michelle Konzack <linux4michelle@tamay-dogan.net>
To: BTS <submit@bugs.debian.org>
Subject: [Syntax] UPDATED: file extension for "sh"
Date: Tue, 14 Oct 2008 13:06:47 +0200
[Message part 1 (text/plain, inline)]
Package: mc
Severity: wishlist
Hello Winnie,
I find it realy annoying, if I put something in my BaSH configs and have
NO syntax hilighting so I have changed the line from
file ..\*\\.sh$ Shell\sScript ^#!\s\*/(.\*/|usr/bin/env\s)([a-z]?|ba|pdk)sh
include sh.syntax
to
file .\*(bash_completion|profile|\\.(sh|bash_login|bash_profile|bash_logout|bash_aliases|bash_exports|bash_history|bash_userstuff|bashrc|profile))$ Shell\sScript ^#!\s\*/(.\*/|usr/bin/env\s)([a-z]?|ba|pdk)sh
include sh.syntax
which now coloriser my BaSH configs nicely...
(See attached screenshot)
Thanks, Greetings and nice Day/Evening
    Michelle Konzack
    Systemadministrator
    24V Electronic Engineer
    Tamay Dogan Network
    Debian GNU/Linux Consultant

Note

Original attachments:

• 0001-Ticket-2127.patch (raw) by zaytsev (@zyv) on Apr 1, 2010 at 11:18 UTC

[mc-butler]

Changed by zaytsev (@zyv) on Apr 1, 2010 at 11:18 UTC

• Attachment 0001-Ticket-2127.patch (raw) added

[mc-butler]

Changed by zaytsev (@zyv) on Apr 19, 2010 at 8:52 UTC (comment 1)

• Severity changed from no branch to on review

Branch: 2127_sh_ext (parent: master)
Changeset: [66ab789e4c6424899baa4698d20b5560dd3a36c9]

[mc-butler]

Changed by zaytsev (@zyv) on Apr 24, 2010 at 19:32 UTC (comment 2)

• Owner set to zaytsev
• Status changed from new to accepted

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 25, 2010 at 6:42 UTC (comment 3)

• Component changed from mc-core to mcedit

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 25, 2010 at 6:44 UTC (comment 4)

• Description edited

I think, .bash_history is not a shell script. :)

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 11:26 UTC (comment 5)

• Keywords set to stable-candidate

This is arguable :) my .bash_history, for instance is a huge shell script, because it contains nothing else, but commands I executed for bash ;)

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 25, 2010 at 12:30 UTC (comment 6)

• Votes set to andrew_b

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 12:36 UTC (comment 7)

• Votes changed from andrew_b to andrew_b zaytsev

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 12:36 UTC (comment 8)

• Severity changed from on review to approved
• Votes andrew_b zaytsev deleted

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 12:41 UTC (comment 9)

• Resolution set to fixed
• Status changed from accepted to testing
• Votes set to commited-master

Merged to master, changeset: [f946551] .

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 12:42 UTC (comment 10)

• Severity changed from approved to merged

[mc-butler]

Changed by zaytsev (@zyv) on Apr 25, 2010 at 12:46 UTC (comment 11)

• Keywords stable-candidate deleted
• Votes changed from commited-master to commited-master commited-stable
• Status changed from testing to closed

Cherry-picked to 4.7.0-stable, changeset: [1824a59] .

[mc-butler]

Changed by andrew_b (@aborodin) on May 2, 2010 at 12:21 UTC (comment 12)

What about Ossi's note about bash_userstuff: http://groups.google.com/group/mc-commits/msg/b0342245a16055c8

[mc-butler]

Changed by zaytsev (@zyv) on May 2, 2010 at 12:27 UTC (comment 13)

Hi!

I don't read this list (actually, I feel it should be made read-only so that all of the discussion happens on Trac and the list serves informational purpose only and no important points get lost), but his point is valid. However, I have a habit of never modifying the RegExps that work. If he wants to make a "better" RegExp I will be the first to vote for it.

Z.

[mc-butler]

Changed by andrew_b (@aborodin) on May 2, 2010 at 12:37 UTC (comment 14)

OK, regexp is valid and works. But what is bash_userstuff, though? I think, we should remove it.

[mc-butler]

Changed by zaytsev (@zyv) on May 2, 2010 at 12:42 UTC (comment 15)

I don't mind. I guess this was OP's weird name to separate common things from .bashrc and .profile. Shall we/I use direct commits on top of the tree or you will take care of it?

[mc-butler]

Changed by andrew_b (@aborodin) on May 2, 2010 at 13:05 UTC (comment 16)

For master, we/you can use 2097_cleanup_master branch. For 4.7.0-stable there is no such branch, therefore direct commit can be used.

[mc-butler]

Changed by zaytsev (@zyv) on May 2, 2010 at 14:32 UTC (comment 17)

Please checkout [59a1440e99cff54ec9fc85c82bfd207da2d0500f] . I can later cherrypick it to stable.

[mc-butler]

Changed by zaytsev (@zyv) on May 3, 2010 at 8:44 UTC (comment 18)

Done, thanks.