[mc-ru-fork] patch for fix bug 'The shell is already running a command'

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/213
Reporter	slavazanko (@slavaz)
Mentions	r0polach@….com, mantas@….lt, midenok@….ru

Test case:

• run mc
• press CTRL+o (hide panels)
• press 'space' key
• press 'backspace' key
• press CTRL+o (show panels)
• type 'ls' and press 'enter' key

Note

Original attachments:

• 213_busy_shell.001.patch (raw) by slavazanko (@slavaz) on Jan 27, 2009 at 8:36 UTC
• mc_poc.diff (raw) by midenok (midenok@….ru) on Aug 5, 2009 at 19:03 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 27, 2009 at 8:34 UTC (comment 1)

• Keywords set to review
• Owner set to slavazanko
• Milestone changed from 4.7 to 4.6.2
• Status changed from new to accepted

Created branch '213_busy_shell'; parent branch: mc-4.6

Also, patch 213_busy_shell.001.patch attached.

Review, please.

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 27, 2009 at 8:36 UTC

• Attachment 213_busy_shell.001.patch (raw) added

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 27, 2009 at 8:38 UTC (comment 2)

This not good fix, I know. But at this time no better variants... therefore this patch I propose for fix issue with 'busy shell'.

[mc-butler]

Changed by styx (@styx) on Jan 27, 2009 at 10:04 UTC (comment 3)

• Keywords changed from review to review, vote-styx

[mc-butler]

Changed by winnie (@winnieXY) on Jan 27, 2009 at 11:06 UTC (comment 4)

• Keywords changed from review, vote-styx to rework

Sorry no vote from me.. this patch should be reworked as it's a hack. We should try to fix this issue really and do not try to fix it in a hackish way.

Please rework it.

[mc-butler]

Changed by styx (@styx) on Jan 27, 2009 at 20:21 UTC (comment 5)

• Milestone changed from 4.6.2 to 4.6.3
• Priority changed from major to blocker

moved to 4.6.3 to release 4.6.2 faster
this is a blocking bug

[mc-butler]

Changed by r0polach (r0polach@….com) on Jan 27, 2009 at 20:29 UTC (comment 6)

• Cc set to r0polach@….com

[mc-butler]

Changed by slyfox (@trofi) on Feb 22, 2009 at 14:07 UTC (comment 7)

• Milestone changed from 4.6.2.1 to 4.6.3

[mc-butler]

Changed by slyfox (@trofi) on Feb 22, 2009 at 14:08 UTC (comment 8)

Moving to 4.6.3 as 4.6.2.1 is a primarily build fix release

[mc-butler]

Changed by mantas (mantas@….lt) on Apr 17, 2009 at 16:35 UTC (comment 9)

• Cc changed from r0polach@….com to r0polach@….com, mantas@….lt

[mc-butler]

Changed by slavazanko (@slavaz) on May 8, 2009 at 13:16 UTC (comment 10)

• Milestone changed from 4.6.3 to 4.7

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jun 17, 2009 at 16:15 UTC (comment 11)

• Milestone changed from 4.7 to 4.7.0-pre1

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jun 18, 2009 at 14:39 UTC (comment 12)

• Milestone changed from 4.7.0-pre1 to 4.7

[mc-butler]

Changed by midenok (midenok@….ru) on Aug 5, 2009 at 19:03 UTC

• Attachment mc_poc.diff (raw) added

Busy shell and stacked prompt glitches fix (proof of concept)

[mc-butler]

Changed by midenok (midenok@….ru) on Aug 5, 2009 at 19:19 UTC (comment 13)

• Severity set to no branch

mc_poc.diff fixes busy shell glitch, but is not ready for production merging because:

• it is only for bash;
• subshell state names, pipe names are not good;
• probably state logic should be reworked, states count reduced and variable subshell_ready removed;
• there is no need to send $BASH_COMMAND on pipe, it was used for debugging;
• quick hack for 'stacked prompts bug' use direct ANSI codes. Probably should use ncurses or slang (slang is a bit clumsy for this);
• wrong style (uses spaces instead of tabs);

But this patch works good at least in my tests and my serve as a base to a nicer fix.

[mc-butler]

Changed by midenok (midenok@….ru) on Aug 5, 2009 at 19:20 UTC (comment 14)

• Cc changed from r0polach@….com, mantas@….lt to r0polach@….com, mantas@….lt, midenok@….ru

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 2, 2009 at 21:28 UTC (comment 15)

• Milestone changed from 4.7 to 4.7.0-pre4

I think, time to close this epic bug :)

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 3, 2009 at 10:42 UTC (comment 16)

• Keywords rework deleted

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 16, 2009 at 11:43 UTC (comment 17)

recreated branch 213_busy_shell

initial [4db3447]

Fix issue: Now 'busy shell' status toggle on if user will press 'Enter' key.
Old behavior: User was press any key into subshell and 'busy shell' status toggle on.

Also, patch will enter new behavior:

• run mc
• press ctrl+o (hide panels)
• type 'cat ' and don't press 'Enter' key
• press ctrl+o (show panels)
• type 'ls' and press enter

You'll see:

 cat: ls: File not found.

Review, please.

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 16, 2009 at 11:43 UTC (comment 18)

• Severity changed from no branch to on review

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 16, 2009 at 12:02 UTC (comment 19)

• Votes set to andrew_b

[4db3447]

Cool! It really works! My vote here.

[mc-butler]

Changed by iNode (@iNode) on Oct 16, 2009 at 12:13 UTC (comment 20)

• Severity changed from on review to approved
• Votes changed from andrew_b to andrew_b iNode

Interesting idea... Thanks!

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 16, 2009 at 12:28 UTC (comment 21)

• Status changed from accepted to testing
• Votes changed from andrew_b iNode to commited-master
• Severity changed from approved to merged
• Resolution set to fixed

merge [890f268]

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 16, 2009 at 12:29 UTC (comment 22)

• Status changed from testing to closed

[mc-butler]

Changed by ossi (@ossilator) on Jan 5, 2014 at 15:38 UTC (comment 23)

• Branch state set to no branch

resulted in #2110

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 5, 2014 at 16:17 UTC (comment 24)

• Branch state changed from no branch to merged