Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer does't make horizontal scroll to the found text. #2132

Open
mc-butler opened this issue Apr 5, 2010 · 8 comments
Open

Viewer does't make horizontal scroll to the found text. #2132

mc-butler opened this issue Apr 5, 2010 · 8 comments
Labels
area: mcview mcview, the built-in text editor prio: low Minor problem or easily worked around

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2132
Reporter andrew_b (@aborodin)
Mentions gotar@….pl, egmont@….com (@egmontkob)

With a long lines, if the text is found for the right of the screen, viewer doesn't make horizontal scroll to the found text.

How to reproduce:

  1. Open file with long lines (Makefile of MC is good for this) in non-wrap mode.
  2. Try search '-Wno-long-long' text.
  3. Search is successful, but found text is not shown in the screen, because it is located at 235 column. but screen width is less than 235. Viewer made vertical scroll only to the line with found text.
@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 26, 2010 at 10:26 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on May 26, 2010 at 20:23 UTC (comment 2)

  • Cc set to gotar@….pl

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 17, 2010 at 6:02 UTC

(In #2283) Replying to egmont:

The logic that modifies col (e.g. col += width, col -= width etc.) assume that width and bytelenght are the same notions (because col actually means offset in the file), hence does not handle UTF-8 or CJK (double width) characters correctly.

Yes, this is the known issue. At least the #2132 ticket requires such fix.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 31, 2011 at 20:05 UTC (comment 4)

  • Status changed from accepted to assigned
  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases
  • Owner slavazanko deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 23, 2015 at 16:54 UTC (comment 5)

Ticket #3421 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on Mar 23, 2015 at 17:29 UTC (comment 6)

  • Cc changed from gotar@….pl to gotar@….pl, egmont@….com

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 13, 2022 at 3:25 UTC (comment 7)

Ticket #4406 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by al12345 (alexrats@….com) on Sep 15, 2022 at 1:47 UTC (comment 8)

In the wrapped mode, it doesn't scroll down to the found fragment, either.

Any chance to get it fixed (12 years old!), at least for the ASCII character set?

@mc-butler mc-butler marked this as a duplicate of #2332 Feb 28, 2025
@mc-butler mc-butler marked this as a duplicate of #3421 Feb 28, 2025
@mc-butler mc-butler marked this as a duplicate of #4406 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcview mcview, the built-in text editor prio: low Minor problem or easily worked around
Development

No branches or pull requests

1 participant