Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses vs. slang: oversized dialog backgrounds not painted in curses #2157

Closed
mc-butler opened this issue Apr 28, 2010 · 6 comments
Closed
Assignees
Labels
area: tty Interaction with the terminal, screen libraries prio: medium Has the potential to affect progress ver: 4.7.0.4 Reproducible in version 4.7.0.4
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2157
Reporter ralesk (ralesk@….hu)

Some translations (unfortunately at this time Hungarian is one of those, I’m sorry about that :) ) make (among others) the General settings dialog big enough that it doesn’t fit on a 80×25 screen.
As such, we noticed some weird issue with the ncurses build of mc: the moment the dialog breaks up due to not being able to fit on the screen, it won’t get filled with the white colour that it usually has. In the slang build, the dialog does not become see-through even when things break into multiple lines.
One issue is then to fix the ncurses code to fill the broken dialog properly; and the other issue is to do something about dialogs so that they don’t break the way it breaks now.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by ralesk (ralesk@….hu) on Apr 28, 2010 at 10:17 UTC

Example of a broken dialog

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 13, 2010 at 13:26 UTC (comment 1)

  • Milestone changed from 4.7 to 4.7.3
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Keywords set to stable-candidate
  • Severity changed from no branch to on review

Created 2157_ncurses_fill_region branch. Parent branch is master.
[690be6d5b6c4d06ffa9587b0d05f849530e5a8b8]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 14, 2010 at 7:36 UTC (comment 2)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 19, 2010 at 14:25 UTC (comment 3)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 19, 2010 at 17:24 UTC (comment 4)

  • Status changed from accepted to testing
  • Component changed from mc-core to mc-tty
  • Severity changed from approved to merged
  • Votes changed from slavazanko angel_il to committed-master committed-stable
  • Keywords stable-candidate deleted
  • Resolution set to fixed

Merged to master.
[2c7bc9c]

Cherry-picked to 4.7.0-stable.
[8f49310]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 19, 2010 at 17:25 UTC (comment 5)

  • Status changed from testing to closed
  • Description edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tty Interaction with the terminal, screen libraries prio: medium Has the potential to affect progress ver: 4.7.0.4 Reproducible in version 4.7.0.4
Development

No branches or pull requests

2 participants