Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey shouldn't be capitalized #2168

Closed
mc-butler opened this issue May 4, 2010 · 11 comments
Closed

Hotkey shouldn't be capitalized #2168

mc-butler opened this issue May 4, 2010 · 11 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2168
Reporter egmont (@egmontkob)

In some contexts, e.g. in the F9 menu, hotkeys are highlighted using a different color, no matter if it's an uppercase or lowercase letter. Capitalization of the letters is independent of the hotkey: the first letter, and acronyms are capitalized.

In some other contexts, e.g. in the file copy dialog, hotkeys are the ones that are capitalized, instead of the first letter. For example, there's a "diVe into subdir" instead of "Dive into subdir", since V is the hotkey.

These two looks are inconsistent. I think we should decide on one of the schemes and consistently go with that one.

I personally recommend going with the current scheme of the F9 menu. Hotkeys are already highlighted by the color; I don't see any point in using yet another attribute (uppercase) for emphasizing them even more. Capitalizing a letter in the middle of a word looks ugly. The scheme cannot really be used if there's an acronym, or at least it would really look weird. Moreover, some translations might already be using that scheme (I only checked Hungarian and that one is consistent with itself: even in the file copy dialog it always capitalizes the first word, not the hotkey.)

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on May 7, 2010 at 8:11 UTC (comment 1)

fwiw, http://blog.i18n.ro/keyboard-shortcuts-and-mnemonics-or-accelerators-are-not-the-same-thing/

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 7, 2010 at 9:56 UTC (comment 2)

What about languages without capitalized letters (Arabic, Japan, Chiese, Korean etc)?

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on May 7, 2010 at 11:34 UTC (comment 3)

Using the terminology of that website, this bugreport is about mnemonics.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 14, 2010 at 11:43 UTC (comment 4)

  • Owner set to andrew_b
  • Blocked by set to #320
  • Status changed from new to accepted

Most of this issues are fixed in #320.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 14, 2010 at 12:36 UTC

  • Blocked by #320 deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 15, 2010 at 7:16 UTC (comment 6)

  • Severity changed from no branch to on review
  • Version changed from 4.7.0.4 to master
  • Milestone changed from 4.7 to 4.7.3

Created 2168_capitalized_hotkeys branch. Parent branch is master.
[cdc96f4f6d1299e3a4c7f55450b2749abf67ee90]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 22, 2010 at 12:55 UTC (comment 7)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 25, 2010 at 18:20 UTC (comment 8)

  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on May 25, 2010 at 18:20 UTC (comment 9)

  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 26, 2010 at 6:01 UTC (comment 10)

  • Severity changed from approved to merged
  • Votes changed from slavazanko angel_il to committed-master
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.
[9a97d08]\

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 26, 2010 at 6:02 UTC (comment 11)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants