Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if 256 colors are used but not available #2173

Closed
mc-butler opened this issue May 6, 2010 · 8 comments
Closed

Warn if 256 colors are used but not available #2173

mc-butler opened this issue May 6, 2010 · 8 comments
Labels
area: tty Interaction with the terminal, screen libraries prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2173
Reporter egmont (@egmontkob)

This is the last bit I just did not have time and passion to add to the 256-color patch (ticket #2169).

If 256 colors are not available according to $TERM (ncurses: NCOLORS; slang: I don't know), but the requested color scheme would use any of these extended colors, currently some weird magic happens that is totally not user friendly (you end up with ugly or even unusable colors). Instead, mc could revert to the default skin (or keep the current one if dynamically changing: ticket #2165), and show an error message explaining to the user what happened.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on May 7, 2010 at 8:19 UTC (comment 1)

it should be possible to bind the color scheme setting to a particular $TERM, like is done with the key remappings. otherwise users who use two different terminal types (say, xterm and vga console) on a regular basis might be mightily annoyed.

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on May 7, 2010 at 11:38 UTC (comment 2)

Yup great idea!
(By the way, the popup would still be nice to detect config errors or when the command line refers to an incompatible skin.)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 11, 2010 at 7:51 UTC (comment 3)

If user wants use 256-colors skin, he must choose the terminal with 256 colors support. I'm sure that mc should not be blamed for the fact that user tries to use 256-color skin in terminal which does not support 256 colors. mc should't do fallback itself to the any other skin.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jun 11, 2010 at 21:45 UTC (comment 4)

sorry, did you actually understand what we wrote? it doesn't seem so ...

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 5, 2010 at 20:31 UTC (comment 5)

  • Milestone changed from 4.7.3 to 4.7.4

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 18, 2011 at 11:46 UTC (comment 6)

  • Version changed from version not selected to master
  • Component changed from mc-core to mc-tty
  • Blocked by set to #2169
  • Milestone changed from 4.7.4 to 4.8.0-pre1

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 24, 2011 at 13:50 UTC

  • Blocked by #2169 deleted

(In #2169) merge [6ab2753]

git log --pretty=oneline 1b99570..0f2578d

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 24, 2011 at 14:12 UTC (comment 8)

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in 2169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tty Interaction with the terminal, screen libraries prio: low Minor problem or easily worked around
Development

No branches or pull requests

1 participant