mcdiff shortcut

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2177
Reporter	gotar (gotar@….pl)

mc.keymap defines:

CmdCompareDirs = d
CmdDiffView = ctrl-y

it would be more logical to have CmdDiffView under ctrl-d xmap.

[mc-butler]

Changed by slavazanko (@slavaz) on May 6, 2010 at 9:44 UTC (comment 1)

Just create mc.keybind.gotar and attach to this ticket ;)

[mc-butler]

Changed by gotar (gotar@….pl) on May 6, 2010 at 10:53 UTC (comment 2)

It doesn't make any sense to create alternate keymap for just one binding. I'd prefer default to be changed to something better as it's still new feature.

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 28, 2010 at 17:38 UTC (comment 3)

Actually, the c-x c-y shortcut is already used for a long time. I think this thicket should be closed as wontfix.

[mc-butler]

Changed by gotar (gotar@….pl) on Sep 29, 2010 at 9:46 UTC (comment 3.4)

I don't share your opinion:

1. mcdiff exists only in development branch, so according to your own statement from permission_mode setting from 4.7.2 config ignored #2305 comment 6 (and 3 above) this is not an argument,

2. even if some of you are so attached to existing shortcut, it's possible to reserve second keystroke to the CmdDiffView.

All I'd like to get are fine working defaults for next stable release, so if you think ctrl-y is logical (I don't even know a language wich has 'y' in 'difference') please close this, as personally I don't have any problems in changing mc.keymap locally.

[mc-butler]

Changed by slavazanko (@slavaz) on Sep 29, 2010 at 12:02 UTC (comment 5)

• Owner set to slavazanko
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Sep 29, 2010 at 12:12 UTC (comment 6)

• Milestone changed from 4.7 to 4.7.5
• Severity changed from no branch to on review
• Version changed from version not selected to master

Created branch 2177_change_cmddiff_shorcut (parent: master)
Initial [a345d9ec68728f90fea6968c73cd4c45f444f9bc]

Review, please.

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 29, 2010 at 12:44 UTC (comment 7)

• Votes set to andrew_b
• Component changed from mc-config-ini to mc-core

Ok. My vote here.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Sep 29, 2010 at 13:30 UTC (comment 8)

• Severity changed from on review to approved
• Votes changed from andrew_b to andrew_b angel_il

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 12, 2010 at 10:06 UTC (comment 9)

• Status changed from accepted to testing
• Resolution set to fixed
• Votes changed from andrew_b angel_il to commited-master
• Severity changed from approved to merged

Merged to master; changeset: [8f4ccc8]

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 12, 2010 at 10:08 UTC (comment 10)

• Status changed from testing to closed

[mc-butler]

Changed by dborca (dborca@….com) on Feb 22, 2011 at 16:14 UTC (comment 4.11)

Replying to gotar:

All I'd like to get are fine working defaults for next stable release, so if you think ctrl-y is logical (I don't even know a language wich has 'y' in 'difference') please close this, as personally I don't have any problems in changing mc.keymap locally.

I don't know a language wich has '?' in 'Find File', either. But that's not the point. The point is that you don't know many languages. Like, "man diff", for example:

-y --side-by-side

Output in two columns.

But don't mind me. Feel free to shuffle a random number of shortcuts in each release.