Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcedit quit dialog #2265

Closed
mc-butler opened this issue Jul 8, 2010 · 24 comments
Closed

mcedit quit dialog #2265

mc-butler opened this issue Jul 8, 2010 · 24 comments
Assignees
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.7.3 Reproducible in version 4.7.3
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2265
Reporter masics (masics@….com)
Mentions zaytsev (@zyv)

Please revert change of mcedit quit dialog - we are working with different versions and it is very confusing.
In old versions it was "[ Cancel quit ] [ Yes ] [ No ]" while in the new it is "[ Yes ] [ No ] [ Cancel quit ]".

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 8, 2010 at 9:29 UTC (comment 1)

  • Version changed from 4.7.2 to 4.7.3
  • Priority changed from major to trivial

In all MC dialogs button [OK] is at left, button [Cancel] is at right.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 8, 2010 at 9:30 UTC (comment 2)

  • Summary changed from ncedit quit dialog to mcedit quit dialog

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 10:48 UTC (comment 3)

  • Cc set to zaytsev

I don't think that reverting this dialog to an inconsistent state is not a good idea. As you upgrade all the machines the problem will disappear, but if it's reverted now, then there will never be an opportunity to standardize it, because every time people will be telling that they are running into problems in the transition phase.

Also I think they way you use this dialog is wrong, because you rely on the positions of the buttons (which can change) instead of accelerators (which should never change). Just use c, y and & n to select the buttons instead of the arrows and it will work independently of the mc version.

I agree, however, that it would be nice to set Cancel quit as a default (not change the position of the buttons, just make it selected by default).

@mc-butler
Copy link
Author

Changed by masics (masics@….com) on Jul 8, 2010 at 10:53 UTC (comment 4)

in version 4.6.1 it is different.
We are all used to use this dialog for years. The new version of MC will not be included into RH4 and I'm not sure about RH5. So, this is very disappointing to LOOSE changes because of this "standardization".

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 10:58 UTC (comment 5)

This is not a valid argument. You can always update mc from my repositories (I will fix the build bot as soon as I can find time for it). It's not a core component of RHEL which can influence the reliability and stability of the system.

The reason why you are LOOSING changes now is that you made a wrong habit and now are enjoying the consequences. Why wouldn't you use accelerators instead, so that you will never have any problems like this in the future?

To me it's a wontfix.

@mc-butler
Copy link
Author

Changed by masics (masics@….com) on Jul 8, 2010 at 11:04 UTC (comment 6)

My "bad habit" is based on speed. It is much faster to press Esc-Esc-right-enter than moving fingers to 'y' key. Also, you might re-think saving, so you have time to cancel it.
I can update mc at home but at work I am not in charge and have no root rights.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 11:09 UTC (comment 7)

Pressing Esc-Esc-y is no slower than Esc-Esc-Right-Enter since you are using your both hands anyway, unless you have some very special non-standard finger layout. If you want to cancel saving just take a pause after you type Esc-Esc.

What's the problem to compile it at home an unpack to ~/opt at work? Works fine for me.

@mc-butler
Copy link
Author

Changed by masics (masics@….com) on Jul 8, 2010 at 11:34 UTC (comment 8)

This change just made me and other people angry.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 12:44 UTC (comment 9)

That's life...

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jul 8, 2010 at 12:52 UTC (comment 10)

  • Status changed from new to closed
  • Resolution set to wontfix

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 8, 2010 at 13:22 UTC (comment 11)

  • Status changed from closed to reopened
  • Resolution wontfix deleted

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jul 8, 2010 at 13:23 UTC (comment 12)

Ticketstarter: may be, good way for resolve your trouble is make default focus on [cancel] button? In this case, behaviour of exit dialog will returns...

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 13:25 UTC (comment 13)

  • Status changed from reopened to assigned
  • Owner set to andrew_b

This ticket has been reopened to make the following change: the order of the buttons stay the same as right now, but upon the creation of the dialog the focus is on the [ Cancel quit ] button.

@mc-butler
Copy link
Author

Changed by lly (lly.dev@….com) on Jul 8, 2010 at 15:40 UTC (comment 14)

I also vote to return old mcedit quit dialog behavior - [Cancel quit] by default, [Yes] by one press right button.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 8, 2010 at 16:39 UTC (comment 15)

  • Severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.4

Created 2256_edit_quit_dialog_buttons branch. Parent branch is master.
[f660c97]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 8, 2010 at 16:43 UTC (comment 16)

  • Votes set to zaytsev

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 8, 2010 at 17:16 UTC (comment 17)

  • Votes changed from zaytsev to zaytsev angel_il
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 8, 2010 at 17:31 UTC (comment 18)

  • Votes changed from zaytsev angel_il to committed-master
  • Status changed from assigned to testing
  • Severity changed from approved to merged
  • Resolution set to fixed

Merged to master.
[f660c97]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 8, 2010 at 17:33 UTC (comment 19)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jul 11, 2010 at 8:52 UTC (comment 20)

  • Resolution fixed deleted
  • Status changed from closed to reopened

i'm against this change. this "quit sequence" is so laborious that i got into the habit of explicitly pressing f2 before hitting escape. no other editor i know would default to cancel - simply because it makes totally no sense.

to make the angry "legacy users" less angry, one could implement this "ui hack": if the discard button is activated a) within one (half?) second of opening the dialog and b) with the enter/space key, then show a second confirmation dialog. the dialog would also have a "never ask again" checkbox. this shouldn't be too annoying for everyone else. the hack could be removed after two years or so.

on a related note, the question should be "File was modified. Save before quitting?". otherwise "no" and "cancel quit" would be logically equivalent.

@mc-butler
Copy link
Author

Changed by Polynomial-C (polynomial-c@….de) on Jul 13, 2010 at 9:42 UTC (comment 21)

I'm strongly for this change. As a happy user of midnight-commander for nearly twelve years now I got so used to this behaviour that it's very hard to get rid of it. Without this change I had to edit files several times because I always did "F10 -> cursor right -> enter" which resulted in the file not being saved.
If you really want to get the default changed please leave some possibility for users with this habit to return to the old behaviour. Otherwise it would make editing with mc very painful.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2010 at 9:59 UTC (comment 22)

  • Status changed from reopened to closed
  • Resolution set to wontfix

I really don't understand what we are talking about? Before change in 4.7.2 release the buttons were:

[<Cancel quit>] [Yes] [No]

In 4.7.2 release, the order and default button were changed:

[<Yes>] [No] [Cancel quit]

As a result of this ticket, the default button was changed:

[Yes] [No] [<Cancel quit>]

For those, who presses F10->Right->Enter, the behaviour of this dialog is absolutely the same
as was before 4.7.2.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2010 at 10:01 UTC (comment 23)

Ops, sorry... 4.7.3 must be in the previous comment instead of 4.7.2.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 13, 2010 at 10:35 UTC (comment 24)

Amen.

@mc-butler mc-butler closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.7.3 Reproducible in version 4.7.3
Development

No branches or pull requests

2 participants