Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments in trac are not numbered #2280

Closed
mc-butler opened this issue Jul 13, 2010 · 12 comments
Closed

comments in trac are not numbered #2280

mc-butler opened this issue Jul 13, 2010 · 12 comments
Assignees
Labels
area: adm Administrative tasks prio: low Minor problem or easily worked around

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2280
Reporter ossi (@ossilator)
Mentions gotar@….pl

the titles of comments in tickets contain no number, which makes it hard to refer to them. that the reply function creates references with actual numbers makes it look outright silly ...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2010 at 12:05 UTC (comment 1)

What do you propose?

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jul 13, 2010 at 12:36 UTC (comment 2)

i don't know. the comment titles are a somewhat weird "Changed 29 minutes ago by andrew_b", and so on. maybe put that as "comment #1 from 29 minutes ago by andrew_b" or something like that.

@mc-butler
Copy link
Author

Changed by x905 on Jul 14, 2010 at 4:27 UTC

Replying to ossi (#2280):

the titles of comments in tickets contain no number

need to change /usr/local/share/trac/templates/ticket.cs (or where it located) and add "<?cs var:change.cnum?>" to where header forms (i tested it on my local trac 0.10.4)

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 14, 2010 at 8:41 UTC (comment 4)

  • Status changed from new to accepted
  • Owner set to zaytsev

Will do. Thanks.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 14, 2010 at 8:45 UTC (comment 5)

And after the Trac upgrade this change will be missed. Is such feature available in new Trac out-of-box or in any plug-in?

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 14, 2010 at 8:49 UTC (comment 6)

Not that I know of. Either way we already have some customizations to the core and plugins, so an upgrade is tricky business... This is not only Trac's problem, but web-apps in general. That's why there are many opponents to actually packaging them vs. installing and updating manually.

I guess the best bet for the upgrade would anyway be to do a diff against stock versions of Trac and plugins and then try to re-apply relevant changes.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Aug 1, 2010 at 18:55 UTC (comment 6.7)

  • Cc set to gotar@….pl

Replying to zaytsev:

That's why there are many opponents to actually packaging them vs. installing and updating manually.

That's exactly why every piece of software in a system should came from a package. This way one gets:

  1. checksums (easy do detect in-place changes),
  2. backups (e.g. via rpm's repackage function),
  3. source of all the patches and modifications (in src.rpm).

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 2, 2010 at 9:05 UTC (comment 8)

Did you ever tried to do this in practice with the regards to the web applications or it's just a wishful thinking?

On the practical side, this server runs Debian and creating a local Trac fork is such a pita, that it's easier to kill yourself. And even if the overhead of Debian re-packaging can be justified it's extremely complicated to convert an existing setup given how messy and undocumented it is.

Let's see. One day I will get some time... Maybe. Or someone else.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Aug 2, 2010 at 9:33 UTC (comment 8.9)

Replying to zaytsev:

Did you ever tried to do this in practice with the regards to the web applications or it's just a wishful thinking?

Of course I did. I've got to manage bunch of webapps on dozen servers, it would be impossible to maintain them other way. Some changes are even pushed into distro (e.g. http://cvs.pld-linux.org/cgi-bin/cvsweb/packages/phpPgAdmin/phpPgAdmin-calendar.patch), same reason as for #1668 and #2135 in PLD package (no upstream fixes).

On the practical side, this server runs Debian and creating a local Trac fork is such a pita, that it's easier to kill yourself.

Who said 'fork'? Keep your changes in diff format, they rarely need some minor updates only.

And even if the overhead of Debian re-packaging can be justified it's extremely complicated to convert an existing setup given how messy and undocumented it is.

Well, if someone didn't think on proper procedures then, either the time is now ...or postpone it until some else does it.

Let's see. One day I will get some time... Maybe. Or someone else.

:)

But seriously: take original deb package of currently installed version, create diff, try to apply it on some new version.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 2, 2010 at 9:41 UTC (comment 10)

Well, I do manage phpMyAdmin and phpPgAdmin, cacti and the like this way, but it's a very special case of a webapp. We are talking about Trac here, which requires much more (tremendously more) customization than those.

Well, if someone didn't think on proper procedures then, either the time is now ...or postpone it until some else does it.

Exactly. Fortunately it was not me (I wouldn't have gone for Debian in the first place), thus I have another person to blame =) Hi, Winnie! :)

But seriously: take original deb package of currently installed version, create diff, try to apply it on some new version.

This is what I meant by forking and this would probably the way to go, but Debian packaging system is so over-engineered, that it's by now ways as simple as just rebuilding your noarch SPECs with appropriate patches. You have dozens of files to keep in sync and so on...

As I said, let's see. Actually I'd like to have the whole setup re-done properly and this time appropriately DOCUMENTED. One day.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2011 at 11:21 UTC (comment 11)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Version master deleted

Fixed by Trac upgrade to 0.12.2 version.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2011 at 11:21 UTC (comment 12)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: adm Administrative tasks prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants