Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded FISH scripts do not work properly #2347

Closed
mc-butler opened this issue Sep 14, 2010 · 24 comments
Closed

Hardcoded FISH scripts do not work properly #2347

mc-butler opened this issue Sep 14, 2010 · 24 comments
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.5

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2347
Reporter gms (gms_mouse@….ru)
Mentions gotar@….pl, zaytsev (@zyv)

It is not possible to enter any remote diectory except "/" and view any file.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 14, 2010 at 8:03 UTC (comment 1)

Telepathy module is totally broken.

What are you doing? What system are you using?

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Sep 15, 2010 at 5:16 UTC (comment 2)

  • Priority changed from major to trivial
  • Cc set to gotar@….pl

Probably he didn't install separated #2242 files or took some broken distro package. Anyway contrib/dist/redhat/mc.spec.in doesn't seem to include them too.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 15, 2010 at 5:31 UTC (comment 3)

Hm.. rpmbuild show a message about unpacked files in $BUILDROOT. Package builder should look to that messages.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 15, 2010 at 5:33 UTC (comment 4)

But anyway. mc.spec.in must be fixed.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 15, 2010 at 8:07 UTC (comment 5)

  • Cc changed from gotar@….pl to gotar@….pl, zaytsev
  • Version changed from 4.7.4 to master

After the buildbot was destroyed the SPEC is no longer kept current. I have finally created a new KVM host for restoring the buildbot, but I don't have time to setup mock and the whole thing. I hope to get to it sooner or later. Maybe in a few weeks.

@mc-butler
Copy link
Author

Changed by gms (gms_mouse@….ru) on Sep 15, 2010 at 11:30 UTC (comment 1.6)

Replying to andrew_b:

Telepathy module is totally broken.

What are you doing? What system are you using?

I'm using Debian.
In mc 4.7.3 FISH works well, configure options were the same.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 15, 2010 at 11:33 UTC (comment 7)

You are kidding??? Where is mc -V ? Which configure options?

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 15, 2010 at 11:34 UTC (comment 8)

aptitude show mc

@mc-butler
Copy link
Author

Changed by gms (gms_mouse@….ru) on Sep 16, 2010 at 5:57 UTC (comment 7.9)

Replying to zaytsev:

You are kidding??? Where is mc -V ? Which configure options?

LANG=C ./mc -V
GNU Midnight Commander 4.7.4
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

LANG=C mc -V
GNU Midnight Commander 4.7.3
Virtual File Systems: tarfs, extfs, cpiofs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 16, 2010 at 7:28 UTC (comment 10)

Where did you get it? Compiled from source? How did you install it? Are the FISH scripts in place?

@mc-butler
Copy link
Author

Changed by gms (gms_mouse@….ru) on Sep 16, 2010 at 15:02 UTC (comment 11)

Hmm... this bug occurs only when create a debian package (but all the files are in place).
Thanks 2 all!

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 16, 2010 at 15:04 UTC (comment 12)

How did you create a package? How do you know they are in place?

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 16, 2010 at 15:36 UTC (comment 12.13)

Replying to zaytsev:

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

Generally they work but some bugs are present. :)

@mc-butler
Copy link
Author

Changed by gms (gms_mouse@….ru) on Sep 16, 2010 at 16:37 UTC (comment 12.14)

Replying to zaytsev:

How did you create a package? How do you know they are in place?

P.S. This ticket is a nice provocation to get rid of hardcoded FISH scripts since they don't seem to work anyway! :-)

When i do

#./configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib;make;make install

anything works,but when i build deb with debian files from ftp://ftp.debian.org/debian/pool/main/m/mc/mc_4.7.0.9-1.debian.tar.gz

#fakeroot debian/rules binary
#dpkg -i mc_4.7.4-1_i386.deb

FISH becobes broken.
PS: other VFS's still work fine

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 17, 2010 at 11:04 UTC (comment 15)

  • Severity changed from no branch to on review

Branch: 2347_fish_fix
changeset: [f6309b162ea464c7cd3ce0f2903871065f8734e9]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 17, 2010 at 11:04 UTC (comment 16)

  • Status changed from new to accepted
  • Owner set to angel_il

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 17, 2010 at 11:14 UTC (comment 17)

Of course if you build a package for 4.7.4 from my sources for 4.7.0.9 FISH scripts are not going to be installed where they belong. What else did you expect??? New FISH is not backported yet to the stable branch.

What I find annoying is that instead of providing all the details at once, we have to fish them out of you one by one.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 17, 2010 at 11:15 UTC (comment 18)

  • Description edited
  • Summary changed from Bug in FISH to Hardcoded FISH scripts do not work properly

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 18, 2010 at 9:35 UTC (comment 19)

  • Votes set to andrew_b
  • Milestone changed from 4.7 to 4.7.5
  • Priority changed from trivial to major

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 27, 2010 at 9:50 UTC (comment 20)

  • Severity changed from on review to approved
  • Votes changed from andrew_b to andrew_b slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 27, 2010 at 12:36 UTC (comment 21)

  • Status changed from accepted to testing
  • Severity changed from approved to merged
  • Resolution set to fixed
  • Votes changed from andrew_b slavazanko to committed-master

Fixed: [5f81b14]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 27, 2010 at 12:41 UTC (comment 22)

  • Keywords set to stable-candidate

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 15, 2010 at 10:36 UTC (comment 23)

  • Status changed from testing to closed
  • Keywords stable-candidate deleted

Fixed in 4.7.0-stable in #2376.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 15, 2010 at 10:37 UTC (comment 24)

Oops, sorry...
Fixed in 4.7.0-stable in #2367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.5
Development

No branches or pull requests
1 participant
@mc-butler