\0s in left panel after CmdInfo

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2390
Reporter	gotar (gotar@….pl)

Steps to reproduce:

1. use xterm (I've got not UTF one),
2. go to the right panel,
3. ctrl-x i, ctrl-x i (enable and disable Info).

Result: right frame of left panel displays ^{@ regardless of skin used (i.e. it doesn't depend on characters used for frames, in this case dvert). This doesn't happen on plain Linux console.}

Note

Original attachments:

• mc-2390.png (raw) by gotar (gotar@….pl) on Jan 8, 2011 at 12:38 UTC

[mc-butler]

Changed by gotar (gotar@….pl) on Dec 29, 2010 at 1:03 UTC (comment 1)

It happens when terminal has odd count of columns, that's why I didn't reproduce it on my Linux console with even (but got 99 by default on xterm).

[mc-butler]

Changed by gotar (gotar@….pl) on Dec 29, 2010 at 1:06 UTC (comment 2)

And happens with Quick view (ctrl-x q) too.

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 8, 2011 at 7:20 UTC (comment 3)

• Milestone changed from 4.7 to 4.8

Would you show a screenshot illustrated this bug? I don't see any garbage symbols but I see wrong initialization of panel format after switch back to the file listing : columns have incorrect width.

[mc-butler]

Changed by gotar (gotar@….pl) on Jan 8, 2011 at 12:38 UTC

• Attachment mc-2390.png (raw) added

[mc-butler]

Changed by gotar (gotar@….pl) on Jan 8, 2011 at 12:43 UTC (comment 4)

Sure, that's how it looks like just after it happens. Later it's being fixed entirely for a moment (when switching to altered panel) or partially ('@' - after viewing file in good panel).

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 15, 2011 at 15:22 UTC (comment 5)

• Milestone changed from 4.8 to 4.8.0-pre1
• Severity changed from no branch to on review
• Keywords set to stable-candidate

Well, I don't see the defect shown in the screenshot, but I fixed the incorrect listing format initialization.

Created 2390_panel_format_init branch. Parent branch is master.
Initial [41b1c16e75b2e75dbed71ee4a09f9201bcc02a29]

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 15, 2011 at 15:22 UTC (comment 6)

• Owner set to andrew_b
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 18, 2011 at 12:18 UTC (comment 7)

• Votes set to slavazanko

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 19, 2011 at 9:24 UTC (comment 8)

• Votes changed from slavazanko to slavazanko angel_il

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jan 19, 2011 at 9:29 UTC (comment 9)

• Severity changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 19, 2011 at 10:06 UTC (comment 10)

• Resolution set to fixed
• Votes changed from slavazanko angel_il to committed-master committed-stable
• Severity changed from approved to merged
• Status changed from accepted to testing
• Keywords stable-candidate deleted

Merged to master.
[d21eb43]

git log --pretty=oneline 86d57f2..d21eb43

Cherry-picked to 4.7.5-stable
[e199a84]

git log --pretty=oneline adbf5f3..4b288c0

Cherry-picked to 4.7.0-stable
[da9d40119f355db2a001eb60aedbe7ed37384deb]

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 19, 2011 at 10:06 UTC (comment 11)

• Status changed from testing to closed