Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile.syntax colors not completely honored #2507

Closed
mc-butler opened this issue Feb 21, 2011 · 5 comments
Closed

makefile.syntax colors not completely honored #2507

mc-butler opened this issue Feb 21, 2011 · 5 comments
Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2507
Reporter curtis (@dotysan)
Mentions gotar@….pl

Leading tab whitespace on Makefile is defined as background red. This works in legacy mc-4.6, but the introduction of editwhitespace skin element prevents proper display.

Example attached. Upper session is legacy showing proper color. Lower shows current/wrong behavior.

The syntax colors should override the skinned color elements, yes? Or is there a way to undef a particular skin color such as editwhitespace in a Syntax definition?

Not sure if this is best fixed in mcedit or mc-skin component.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by curtis (@dotysan) on Feb 21, 2011 at 18:46 UTC

compare 4.6-legacy vs. current Makefile colors

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Feb 21, 2011 at 19:16 UTC (comment 1)

just switch off [x] Visible tabs

@mc-butler
Copy link
Author

Changed by curtis (@dotysan) on Feb 21, 2011 at 20:04 UTC (comment 2)

  • Type changed from defect to enhancement

Good workaround. Maybe this is a feature request then...for corner case where visible tabs is usually desired on, but overridden by Makefile syntax.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 22, 2011 at 8:14 UTC

  • Status changed from new to closed
  • Milestone 4.8 deleted
  • Resolution set to duplicate
  • Version 4.7.5 deleted

Replying to curtis (#2507):

The syntax colors should override the skinned color elements, yes? Or is there a way to undef a particular skin color such as editwhitespace in a Syntax definition?

Let discuss about this point in #2172.

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Mar 1, 2011 at 21:10 UTC (comment 4)

  • Cc set to gotar@….pl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around
Development

No branches or pull requests

1 participant