File size column is bogus for widths above 9

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2580
Reporter	ply (ply@…-online.hu)

The panel column for the file sizes displays a value formatted according to the column width. However, width values above 9 produce undefined behavior. For example the width of 10 displays all file sizes in kilobytes, the width of 11 in megabytes, and the width of 12 again in bytes.

This is probably due to the function size_trunc_len in lib/util.c using a fixed array of constants that have values only up to 9 decimal places, and not checking for this limit. Please add a check, and a couple of more allowed widths, to let me use 10 digits for my file sizes. :-)

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 28, 2011 at 8:46 UTC (comment 1)

• Owner set to andrew_b
• Milestone changed from Future Releases to 4.8.0-pre2
• Status changed from new to accepted
• Branch state changed from no branch to on review

Branch: 2580_file_size_column (parent: master).
Initial [111213688eb3f4d2bd5439d799e9bc5c116e6ace]

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 28, 2011 at 8:46 UTC (comment 2)

• Keywords set to stable-candidate
• Version changed from 4.8.0-pre1 to master

[mc-butler]

Changed by slavazanko (@slavaz) on Aug 29, 2011 at 10:41 UTC (comment 3)

• Votes set to slavazanko

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 29, 2011 at 19:48 UTC (comment 4)

• Votes changed from slavazanko to slavazanko angel_il
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 30, 2011 at 17:41 UTC (comment 5)

• Status changed from accepted to testing
• Branch state changed from approved to merged
• Votes changed from slavazanko angel_il to committed-master
• Resolution set to fixed

Merged to master.
[8353224]

git log --pretty=oneline 4aebb59..8353224

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 8, 2011 at 11:01 UTC (comment 6)

• Status changed from testing to closed
• Votes changed from committed-master to committed-master committed-stable
• Keywords stable-candidate deleted

Cherry-picked to 4.7.5-stable.
Initial [6d5ea74]