[patch ready] mc does not preserve file mtime when copying over ssh

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2625
Reporter	sergem
Mentions	gotar@….pl

mc does not preserve file mtime when copying over ssh

Attached patch should fix this problem.

Note

Original attachments:

• mc-4.7.5.5-sshutime.patch (raw) by sergem on Oct 6, 2011 at 22:31 UTC
• mc-4.7.5.5-sshutime-perl.patch (raw) by sergem on Oct 7, 2011 at 13:50 UTC

[mc-butler]

Changed by sergem on Oct 6, 2011 at 22:31 UTC

• Attachment mc-4.7.5.5-sshutime.patch (raw) added

[mc-butler]

Changed by sergem on Oct 7, 2011 at 13:50 UTC

• Attachment mc-4.7.5.5-sshutime-perl.patch (raw) added

Same patch, but using perl utime and fallback to touch if no perl found

[mc-butler]

Changed by gotar (gotar@….pl) on Oct 10, 2011 at 10:47 UTC (comment 1)

• Cc set to gotar@….pl

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 10, 2011 at 12:28 UTC (comment 2)

• Status changed from new to accepted
• Owner set to slavazanko

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 10, 2011 at 13:34 UTC (comment 3)

• Milestone changed from Future Releases to 4.8
• Branch state changed from no branch to on review
• Keywords set to stable-candidate

Created two branches:

• 2625_fish_mtime (based on master branch, [ce785b401fd3c361c5b03dca238121aabeedd82f])
• 2625_fish_mtime_stable (based on 4.7.5-stable branch, [68652ea50bf597b44e78a59c50e0086185da09a3])

Review, please.

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 22, 2011 at 13:20 UTC (comment 4)

• Blocking set to #51

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 11, 2011 at 13:46 UTC (comment 5)

• Votes set to angel_il

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 11, 2011 at 13:56 UTC (comment 6)

• Votes changed from angel_il to angel_il amdrew_b
• Branch state changed from on review to approved

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 12, 2011 at 8:54 UTC (comment 7)

• Votes changed from angel_il amdrew_b to commited-master
• Resolution set to fixed
• Status changed from accepted to testing
• Branch state changed from approved to merged

Merged to master: [4dde8ca]

git log --pretty=oneline 6f13867..ccb6de9

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 12, 2011 at 9:02 UTC (comment 8)

• Votes changed from commited-master to commited-master commited-stable
• Keywords stable-candidate deleted
• Status changed from testing to closed

Merged to stable:

git log --pretty=oneline ebb5c99..729aaed

[mc-butler]

Changed by ag (andrey.gursky@…-mail.ua) on Dec 12, 2015 at 14:39 UTC (comment 9)

What are the reasons to add and prefer perl over touch? The nanosecond precision [1] would work with touch, but since I can't find "perl utimensat" I'm not sure it would work so easy with perl (without additional modules).

[1] #3575

[mc-butler]

Changed by zaytsev (@zyv) on Jan 1, 2016 at 10:35 UTC (comment 10)

I think that the original motivation for preferring Perl in all cases for FISH if it is available at all was compatibility. We have constantly had problems with FISH scripts not working properly in various settings due to non-POSIXness of available shells and tools, and Perl turned out to be a) very compatible and b) generally faster.

I'm not sure that it's worth reversing the defaults here...

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 10:52 UTC

• Blocking #51 deleted
• Blocked by set to #51

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 10:55 UTC (comment 12)

• Blocked by changed from #51 to #2242