Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory #2695

Closed
mc-butler opened this issue Dec 19, 2011 · 37 comments
Closed

VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory #2695

mc-butler opened this issue Dec 19, 2011 · 37 comments
Assignees
@slavaz
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.2

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2695
Reporter slavazanko (@slavaz)

For unification of the work with patches, we need to expand the vfs_path_t usage to sources related to UI (not only to lib/ subdir).
@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 19, 2011 at 22:00 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 19, 2011 at 22:05 UTC (comment 2)

  • Branch state changed from no branch to on review

Created branch 2695_expansion_to_src
Initial [7f0d3b42f8bd782a3a0667edb7259c66fc69ef8b]

Review, please.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 10, 2012 at 7:19 UTC (comment 3)

  • Branch state changed from on review to on rework

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 11, 2012 at 7:46 UTC

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 13, 2012 at 8:08 UTC (comment 5)

  • Branch state changed from on rework to on review

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 13, 2012 at 8:36 UTC (comment 6)

  • Keywords set to stable-candidate

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 24, 2012 at 5:44 UTC (comment 7)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 27, 2012 at 17:40 UTC (comment 8)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Mar 6, 2012 at 7:24 UTC (comment 9)

  • Keywords stable-candidate deleted
  • Votes changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 6, 2012 at 9:14 UTC (comment 10)

  • Status changed from accepted to testing
  • Votes changed from andrew_b angel_il to committed-master
  • Keywords set to stable-candidate
  • Blocking #62, #2454 deleted
  • Resolution set to fixed
  • Milestone changed from Future Releases to 4.8.2

Merged to master:

git log --pretty=oneline 963ee34...4047403

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 7, 2012 at 19:36 UTC (comment 11)

  • Status changed from testing to reopened
  • Resolution fixed deleted
  • Blocking set to #2608

Have bug with branch:

  • run mc
  • press Shift-F4 (create new file in editor)
  • type any char

segfault here

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 7, 2012 at 19:37 UTC (comment 12)

  • Status changed from reopened to accepted

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 7, 2012 at 19:46 UTC (comment 13)

  • Branch state changed from approved to on review
  • Votes committed-master deleted

Created branch 2695_editor_segfault [f3352a16af98f9d1265b021bc549f33ca7cd2010]

Review, please.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Mar 7, 2012 at 20:13 UTC (comment 14)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 8, 2012 at 4:50 UTC (comment 15)

  • Votes changed from angel_il to angel_il andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 8, 2012 at 6:37 UTC (comment 16)

  • Votes changed from angel_il andrew_b to committed-master
  • Branch state changed from approved to merged
  • Blocking #2608 deleted

Merged to master: [8451286]

@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Mar 10, 2012 at 11:36 UTC (comment 17)

  • Branch state changed from merged to on rework

This change likely led to newly appeared regression.
mc enters busy loop when someone deletes current directory:

$ cd /tmp
$ mkdir x
$ cd x
$ mc
$ rmdir ../x
<black screen. mc 100% busy loops>

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 10, 2012 at 13:30 UTC (comment 17.18)

Fixed in 2740_cleanup.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 12, 2012 at 14:11 UTC (comment 19)

  • mkdir ro_dir
    • chmod 555 ro_dir
    • Shift+F4
    • type any symbols
    • press ESC, try to save

Segfault here.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 12, 2012 at 14:46 UTC (comment 20)

  • Branch state changed from on rework to on review
  • Votes committed-master deleted

Created branch 2695_editor_segfault
Initial [5b787f35899d6e9120992a860614d7db4e614518]

Review, please.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Mar 14, 2012 at 14:07 UTC (comment 21)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 14, 2012 at 17:36 UTC (comment 22)

  • Branch state changed from on review to approved
  • Votes changed from angel_il to angel_il andrew_b

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 15, 2012 at 9:49 UTC (comment 23)

  • Status changed from accepted to testing
  • Votes changed from angel_il andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

merged to master:

git log --pretty=oneline 61ee9ce...0f9083f

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 20, 2012 at 12:51 UTC (comment 24)

Since this ticket is stable - candidate, following commits must be cherry-picked to 4.8.1-stable after porting this ticket to 4.8.1-stable:
[62bbe53]
[8b8c9a4]
[c2406ad]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 8:19 UTC

(In #2753) Merged to master:

git log --pretty=oneline 5b84f73..408ba2a

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 25, 2012 at 12:30 UTC

(In #2758) merged to master:

git log --pretty=oneline 7ae8530..88483f5

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 25, 2012 at 12:35 UTC

(In #2759) merged to master:

git log --pretty=oneline 9d72cf5..d52b1dc

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 25, 2012 at 13:46 UTC (comment 28)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:49 UTC (comment 29)

  • Votes changed from committed-master to committed-master committed-stable
  • Keywords stable-candidate deleted
  • Status changed from testing to closed

Cherry-picked to stable:

git log --pretty=oneline 50a146ce...1e92692

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:51 UTC

(In #2753) Picked to stable as part of #2695

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:52 UTC

(In #2758) Picked to stable as part of #2695

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:53 UTC

(In #2759) Picked to stable as part of #2695

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:54 UTC

(In #2762) Picked to stable as part of #2695

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 12, 2012 at 19:28 UTC

  • Blocked by set to #2765

(In #2765) Created branch 2765_vfs_directory_sizes [72e6dfd2e28fb51e0bc27ba62ed3f9f0da393a8f]

Review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 18, 2012 at 7:36 UTC

  • Blocked by #2765 deleted

(In #2765) Also merged to stable.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 18, 2012 at 13:00 UTC

  • Blocked by set to #2777

(In #2777) created branch 2777_vfs_stale_symlinks [33ea909]

Review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 19, 2012 at 9:00 UTC

  • Blocked by #2777 deleted

(In #2777) Also merged to stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaz slavaz

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.2
Development

No branches or pull requests
2 participants
@slavaz @mc-butler