directory hotlist failing when entries use ~/$HOME

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2747
Reporter	johslarsen (johs.a.larsen@….com)

Reproduce bug

1. (Optional) Create a hotlist with an entry using ~ or $HOME

   echo 'ENTRY "HOME" URL "~"' > ~/.mc/hotlist
   

2. Start mc
3. Open directory hotlist
4. Change to any entry using ~ or $HOME (named HOME if using example from 1.)

Expected output

The directory in the selected panel changes to the URL of the entry (your home directory if using example from 1.)

Result

Error box:

Cannot chdir to "CURRENTDIR/URL_OF_ENTRY"
No such file or directory (2)

First bad commit

Result from using git bisect:

32a9f8257d0417abb4083c801215b4d48ae4933a

MC Version

$ LC_MESSAGES=C src/mc -V
sfs_init(): Warning: file /usr/local/etc/mc/sfs.ini not found
Warning: cannot open /usr/local/libexec/mc/extfs.d directory
GNU Midnight Commander 4.8.1-138-ga742521
Built with GLib 2.30.2
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

$ uname -a
Linux blo 3.2.9-1-ARCH #1 SMP PREEMPT Thu Mar 1 09:31:13 CET 2012 x86_64 AMD Phenom(tm) II X6 1055T Processor AuthenticAMD GNU/Linux

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 6:18 UTC (comment 1)

• Status changed from new to closed
• Keywords hotlist, tilde, ~, home deleted
• Milestone Future Releases deleted
• Version master deleted
• Resolution set to duplicate

What about #2451?

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 6:20 UTC (comment 2)

• Version set to master
• Status changed from closed to reopened
• Resolution duplicate deleted
• Milestone set to Future Releases

Sorry. Tilde is handled incorrectly.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 6:45 UTC (comment 3)

• Status changed from reopened to accepted
• Owner set to andrew_b

[mc-butler]

Changed by johslarsen (johs.a.larsen@….com) on Mar 12, 2012 at 6:59 UTC (comment 4)

$HOME works when prefixing with "/", so I got myself a workaround

Thank you for the help.

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 7:28 UTC (comment 5)

• Branch state changed from no branch to on review
• Keywords set to stable-candidate

Branch: 2747_hotlist_load_fixups (parent: master).
Initial [691d66645e2ebf1e5757b6549c1435d7d2a60ad4]

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 12, 2012 at 7:38 UTC

• Blocked by set to #2118

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 12, 2012 at 7:40 UTC (comment 7)

• Blocked by #2118 deleted

Ops, sorry, errorneus blockedBy

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 12, 2012 at 8:10 UTC (comment 8)

• Votes set to slavazanko

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 12, 2012 at 12:08 UTC (comment 9)

• Votes changed from slavazanko to slavazanko angel_il
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 12:29 UTC (comment 10)

• Resolution set to fixed
• Votes changed from slavazanko angel_il to committed-master
• Status changed from accepted to testing
• Branch state changed from approved to merged

Merged to master.
[61ee9ce]

git log --pretty=oneline a742521..61ee9ce

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 12, 2012 at 12:40 UTC (comment 11)

• Status changed from testing to closed
• Votes changed from committed-master to committed-master committed-stable
• Milestone changed from Future Releases to 4.8.2
• Keywords stable-candidate deleted

Cherry-picked to 4.8.1-stable.
Initial [b534ce7]

git log --pretty=oneline dec6011..62b6023