Last word of help links not clickable

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2763
Reporter	egmont (@egmontkob)

The last word of hyperlinks in the interactive help don't act on mouse clicks. This also implies that one-word links can't be clicked at all.

E.g. on the opening screen of the F1 help, the "Enter", "contents", "authors", "WARRANTY" links can't be clicked with the mouse. The last link, "GNU General Public License" is only followed if you click somewhere on "Gnu General Public " (including the trailing space), but not on "License".

Under "contents" there are many multi-word links, it's easy to verify that it's always the last word that doesn't work.

(My wild guess, without looking at the source, is an off-by-one bug somewhere in the code that wraps the text into lines.)

Note

Original attachments:

• mc-4.8.1.1-help-link-click.patch (raw) by egmont (@egmontkob) on Mar 27, 2012 at 15:06 UTC

[mc-butler]

Changed by egmont (@egmontkob) on Mar 27, 2012 at 15:06 UTC

• Attachment mc-4.8.1.1-help-link-click.patch (raw) added

[mc-butler]

Changed by egmont (@egmontkob) on Mar 27, 2012 at 15:07 UTC (comment 1)

Patch attached.

First the last word should be printed using help_print_word(), and then should the end of the click area be registered using end_link_area().

I think they could both go to CHAR_LINK_POINTER or both to CHAR_LINK_END, it probably wouldn't make a difference.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 27, 2012 at 16:52 UTC (comment 2)

• Owner set to angel_il
• Branch state changed from no branch to on review
• Votes set to angel_il
• Status changed from new to accepted

branch: 2763_help_dialog_fix
parent: master

Please review

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 28, 2012 at 8:51 UTC (comment 3)

• Votes changed from angel_il to angel_il andrew_b
• Keywords set to stable-candidate
• Branch state changed from on review to approved
• Milestone changed from Future Releases to 4.8.3

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 28, 2012 at 10:06 UTC (comment 4)

• Branch state changed from approved to merged
• Votes changed from angel_il andrew_b to committed-master

fixed: [18df85a]

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 28, 2012 at 12:18 UTC (comment 5)

• Resolution set to fixed
• Status changed from accepted to testing

[mc-butler]

Changed by slavazanko (@slavaz) on Apr 22, 2012 at 11:28 UTC (comment 6)

• Votes changed from committed-master to committed-master committed-stable
• Status changed from testing to closed
• Keywords stable-candidate deleted

Cherry-picked to 4.8.1-stable: [d7e6a68].