Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'include' keyword (for command class def) have no effect if it was defined before 'Include' keyword (for commad def). #2773

Closed
mc-butler opened this issue Apr 6, 2012 · 8 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2773
Reporter gavenkoa (@gavenkoa)
Mentions gavenkoa@….com (@gavenkoa)

If I create ~/.config/mc/mc.ext file:

include/video
	Open=echo OK
shell/.avi
    Include=video

and then press RET on .avi file nothing happen.

But if swap this entries I get 'OK' in terminal.


I discover this bug when introduce techniture to merge system wide and own mc.ext file in: #2772 (Suggestion to load /etc/mc/mc.ext before ~/.config/mc/mc.ext anyway or add keyword to mc.ext for this purpose).

For example I want redefine class 'video'. So I put:

include/video
    Open=GOOD-VIEWER %f

then I put content of /etc/mc/mc.ext, which have such lines:

...
### Video ###

regex/\.([aA][vV][iI])$
	Include=video
regex/\.([mM][kK][vV])$
	Include=video

include/video
	Open=BAD_VEWER %f
...

But Open=GOOD-VIEWER %f was ignored and Open=BAD_VEWER %f was taken in account.

Because of this bug I can not just concatenate my settings with system wide, I need use some sed/awk/perl magic...

@mc-butler
Copy link
Author

Changed by gavenkoa (@gavenkoa) on Apr 6, 2012 at 19:10 UTC (comment 1)

I use MC:

GNU Midnight Commander, версия 4.8.1

from Debian wheezy/sid.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 7, 2012 at 4:37 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 7, 2012 at 4:38 UTC

@mc-butler
Copy link
Author

Changed by gavenkoa (@gavenkoa) on Dec 21, 2014 at 16:22 UTC (comment 4)

  • Cc set to gavenkoa@….com

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 17, 2022 at 11:38 UTC

  • Blocked by set to #4141

(In #4141) Branch: 4141_mc.ext.ini
Initial [67ec86b]

mx.ext was moved to INI format from custom one (yet another step to format unification). This allows to implement a task written in the ticket sunmmary.

This is alsow fixes #2773 and #3742.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 25, 2022 at 12:06 UTC (comment 6)

  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.29
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 25, 2022 at 12:09 UTC (comment 7)

  • Status changed from accepted to testing
  • Resolution set to fixed

Fixed in [d9eeec9].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 25, 2022 at 12:11 UTC (comment 8)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants