cygwin test build failure

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2918
Reporter	matzeri (marco.atzeri@….com)

on
tests/lib/mcconfig/Makefile.am
tests/lib/vfs/Makefile.am
tests/src/filemanager/Makefile.am

AM_LDFLAGS = -Wl,-z,muldefs

but on cygwin the linker does not accept the "-z" option and

AM_LDFLAGS = -Wl,--allow-multiple-definition

is needed.

Note

Original attachments:

• 2918_cygwin_muldefs.diff (raw) by andrew_b (@aborodin) on Oct 18, 2012 at 6:17 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 18, 2012 at 6:17 UTC

• Attachment 2918_cygwin_muldefs.diff (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 18, 2012 at 6:18 UTC (comment 1)

Please test the attached patch.

[mc-butler]

Changed by matzeri (marco.atzeri@….com) on Oct 18, 2012 at 9:16 UTC (comment 2)

it is OK.

$ grep -i pass mc-4.8.1.6-1-check.log
PASS: library_independ.exe
PASS: mc_build_filename.exe
PASS: serialize.exe
PASS: x_basename.exe
All 4 tests passed
PASS: config_string.exe
PASS: user_configs_path.exe
All 2 tests passed
PASS: regex_replace_esc_seq.exe
PASS: regex_process_escape_sequence.exe
All 2 tests passed
PASS: canonicalize_pathname.exe
PASS: current_dir.exe
PASS: path_cmp.exe
PASS: path_len.exe
PASS: path_manipulations.exe
PASS: path_serialize.exe
PASS: relative_cd.exe
PASS: tempdir.exe
PASS: vfs_parse_ls_lga.exe
PASS: vfs_path_string_convert.exe
PASS: vfs_prefix_to_class.exe
PASS: vfs_split.exe
PASS: vfs_s_get_path.exe
PASS: path_recode.exe
All 14 tests passed
PASS: do_panel_cd.exe
PASS: examine_cd.exe
All 2 tests passed

[mc-butler]

Changed by slavazanko (@slavaz) on Oct 19, 2012 at 10:17 UTC (comment 3)

• Status changed from new to accepted
• Votes set to slavazanko
• Owner set to slavazanko

Created branch 2918_cygwin_test_build (parent: master).
[fe7ec790fcaadd3faf1ece5ec8bc8dd71647e0e0]

Review, please.

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 19, 2012 at 11:42 UTC (comment 4)

• Milestone changed from Future Releases to 4.8.7

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 20, 2012 at 11:36 UTC (comment 5)

• Keywords set to stable-candidate
• Owner changed from slavazanko to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 20, 2012 at 11:36 UTC (comment 6)

• Branch state changed from no branch to on review

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Nov 14, 2012 at 9:29 UTC (comment 7)

• Branch state changed from on review to approved
• Votes changed from slavazanko to slavazanko angel_il

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 14, 2012 at 9:34 UTC (comment 8)

• Branch state changed from approved to merged
• Votes changed from slavazanko angel_il to committed-master
• Resolution set to fixed
• Status changed from accepted to testing

Merged to master: [4249948].

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 14, 2012 at 9:37 UTC (comment 9)

• Status changed from testing to closed
• Keywords stable-candidate deleted
• Votes changed from committed-master to committed-master committed-stable

Merged to 4.8.1-stable: [2209738].