Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplementation of widget subsystem #2919

Closed
mc-butler opened this issue Oct 22, 2012 · 29 comments
Closed

Reimplementation of widget subsystem #2919

mc-butler opened this issue Oct 22, 2012 · 29 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2919
Reporter andrew_b (@aborodin)

Frist stage:

  1. Derive dialog from widget.
  2. Unification of widget and dialog callback functions and message handling.
  3. Enhance widget capabilities.
  4. New QuickDialog engine that simplifies dialog building.
  5. Build dialogs in normal order only: place widgets from top-left down to bottom-right.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 22, 2012 at 9:17 UTC (comment 1)

  • Owner set to andrew_b
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 22, 2012 at 9:20 UTC (comment 2)

  • Branch state changed from no branch to on review

Branch: 2919_dlg_as_widget (parent: master).
Initial [6abcba470d3934c091d9b498ed48b3063261abfb]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 22, 2012 at 18:18 UTC (comment 3)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 19, 2012 at 12:20 UTC (comment 4)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 20, 2012 at 7:53 UTC (comment 5)

  • Votes changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 20, 2012 at 9:11 UTC (comment 6)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Votes changed from slavazanko angel_il to committed-master

Merged to master: [47fc9f6].

git log --pretty=oneline f45f155..47fc9f6

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 20, 2012 at 9:12 UTC (comment 7)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 28, 2012 at 9:31 UTC (comment 8)

  • Milestone changed from 4.8.7 to Future Releases

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 28, 2012 at 9:32 UTC (comment 9)

  • Status changed from testing to reopened
  • Resolution fixed deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 19, 2016 at 7:33 UTC (comment 10)

  • Branch state changed from merged to on review
  • Votes committed-master deleted
  • Milestone changed from Future Releases to 4.8.18

The next stage: refactoring of widget select/deselect and focus/unfocus:

  • add WOP_SELECTABLE option that shows whether widget can be selected (WInput, WCheck, etc) or not (WLabel, WGauge, etc). Test this option instead of callback call;
  • add WST_FOCUSED state and use it instead widget-own states (WListbox::focused, WButton::selected, WTree::active, etc). Test this option instead of callback call;
  • get rid of multiple widget redraw. In many cases messages MSG_DRAW and MSG_FOCUS (and/or MSG_RESIZE) are sent to widget in series. Handling these messages, widget is redrawn twice (for example, see input_callback(): 
         case MSG_RESIZE:
     case MSG_FOCUS:
     case MSG_UNFOCUS:
     case MSG_DRAW:
         input_update (in, FALSE);
         return MSG_HANDLED;

    MSG_DRAW message handler must be the only place where widget should be drawn. Widget should not draw itself in other message handlers.

Branch: 2919_widget_focus_refactoring
Initial [85040195fabf14534ad47a01b4356cbcad1940bf]

Some dialogs are located in top-left corner. This bug is fixed in 3641_cleanup branch.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 11, 2016 at 8:35 UTC (comment 11)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 11, 2016 at 8:37 UTC (comment 12)

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Votes changed from andrew_b to committed-master
  • Branch state changed from approved to merged

Merged to master: [4d6ea43].

git log --pretty=oneline 9c3fe04..4d6ea43

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 3, 2019 at 11:17 UTC (comment 13)

  • Branch state changed from merged to on review
  • Votes committed-master deleted
  • Status changed from closed to reopened
  • Milestone changed from 4.8.18 to 4.8.23
  • Resolution fixed deleted

Next step: implementation of WGroup widget -- a base class for widgets which contain other widgets.

Branch: 2919_group.
Initial [c36cd25cd44d98bad1ca3309fe5b49502a34cc8b]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 1, 2019 at 16:40 UTC (comment 14)

  • Milestone changed from 4.8.23 to Future Releases
  • Branch state changed from on review to on rework

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 8, 2020 at 17:12 UTC (comment 15)

  • Milestone changed from Future Releases to 4.8.25
  • Branch state changed from on rework to on review

Branch: 2919_group.
Initial [874783d9e73a804064d41bb1421f7a0b1ccc46c5]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 9, 2020 at 8:04 UTC (comment 16)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 9, 2020 at 8:06 UTC (comment 17)

  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
  • Status changed from reopened to closed

Merged to master: [a55b3fb].

git log --pretty=oneline afb09f7cd..a55b3fb68

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 9, 2020 at 8:08 UTC (comment 18)

  • Status changed from closed to reopened
  • Resolution fixed deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 9, 2020 at 8:09 UTC (comment 19)

  • Milestone changed from 4.8.25 to Future Releases
  • Branch state changed from merged to no branch
  • Votes committed-master deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 28, 2021 at 12:52 UTC (comment 20)

  • Milestone changed from Future Releases to 4.8.27
  • Branch state changed from no branch to on review

New widget state: WST_VISIBLE. Applied to make widget visible/invisible.

Branch: 2919_visible
Initial [81aeb633e8de7e62117cf13b237ff2ddaaa94f5d]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 11, 2021 at 14:12 UTC (comment 21)

  • Votes set to andrew_b
  • Branch state changed from on review to merged

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 11, 2021 at 14:13 UTC (comment 22)

  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Status changed from reopened to closed

Merged to master: [0aaf747].

git log --pretty=oneline f67b6c1d0..0aaf74777

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 11, 2021 at 14:14 UTC (comment 23)

  • Status changed from closed to reopened
  • Resolution fixed deleted

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 15, 2021 at 13:39 UTC (comment 24)

  • Milestone changed from 4.8.27 to 4.8.28

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 27, 2022 at 11:31 UTC (comment 25)

  • Milestone changed from 4.8.28 to 4.8.29

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 5, 2023 at 21:52 UTC (comment 26)

  • Milestone changed from 4.8.29 to 4.8.30

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Aug 13, 2023 at 18:56 UTC (comment 27)

  • Milestone changed from 4.8.30 to 4.8.31

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 20, 2024 at 20:04 UTC (comment 28)

  • Milestone changed from 4.8.31 to 4.8.32

Actually are you planning to work on that? :) Just asking, because I keep moving this to the next milestone for the last 2 years...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 21, 2024 at 14:54 UTC (comment 29)

  • Milestone changed from 4.8.32 to 4.8.27
  • Status changed from reopened to closed
  • Resolution set to fixed

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.27
Development

No branches or pull requests
2 participants
@aborodin @mc-butler