race condition when creating tmp dir

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3025
Reporter	Polynomial-C (polynomial-c@….de)

This bug was originally reported at https://bugs.gentoo.org/461284

When there's no mc-tmpdir and a user tries to start two mc sessions simultaneously, sometimes (in one out of ten attempts on my machine) one mc session emits the following error message:

Cannot create temporary directory /tmp/mc-lars: File exists (17)
Temporary files will be created in /tmp
Press any key to continue...

Steps to reproduce:

# rm /tmp/mc-$(whoami) -rf
# uxterm -e mc & uxterm -e mc

You may try any other terminal emulator but it should be one that doesn't take too long to start.

The reporter of the Gentoo bug also provided a patch (which I have attached to this bug) that seems to fix the problem.

Note

Original attachments:

• mc-tmpdir-creation_race_condition_fix.patch (raw) by Polynomial-C (polynomial-c@….de) on Jun 21, 2013 at 8:33 UTC

[mc-butler]

Changed by Polynomial-C (polynomial-c@….de) on Jun 21, 2013 at 8:33 UTC

• Attachment mc-tmpdir-creation_race_condition_fix.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 21, 2013 at 10:19 UTC (comment 1)

• Status changed from new to accepted
• Owner set to andrew_b
• Branch state changed from no branch to on review
• Milestone changed from Future Releases to 4.8.9

Applied. Thnaks!

Branch: 3025_race_cond_reate_tmp_dir
[306382a995ca641d4457d6592daac66b7be634da]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jun 28, 2013 at 19:44 UTC (comment 2)

• Votes set to angel_il

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 5, 2013 at 12:08 UTC (comment 3)

• Votes changed from angel_il to angel_il slavazanko
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 5, 2013 at 17:08 UTC (comment 4)

• Resolution set to fixed
• Votes changed from angel_il slavazanko to committed-master
• Status changed from accepted to testing
• Branch state changed from approved to merged

Merged to master: [33c47b5].

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 5, 2013 at 17:11 UTC (comment 5)

• Status changed from testing to closed