patch vfs becoming permanently stale

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3045
Reporter	mnk (galtgendo@….pl)

I'm not 100% sure (as I haven't downgraded yet), but there has been a major regression between 4.8.8 and 4.8.9 with patch vfs (at least I've only found it in this vfs, but I haven't used others in such way).

The workflow:

• create a patch
• enter vfs, delete a few files, leave vfs
• modify the patch externally (i.e. delete a single chunk from a file)
• reenter vfs

Not only vfs doesn't get updated (as this had happened before too), but now vfs can't be force-released from vfs dialog.

On a related note: I might be wrong here, but that dialog seems to be only one, that getting closed by Down Arrow - that's counter-intuitive and inconsistent.

[mc-butler]

Changed by mnk (galtgendo@….pl) on Jul 21, 2013 at 21:22 UTC (comment 1)

...I've obviously meant "by Right Arrow".

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 22, 2013 at 6:22 UTC

Replying to mnk (#3045):

The workflow:

• create a patch
• enter vfs, delete a few files, leave vfs
• modify the patch externally (i.e. delete a single chunk from a file)

How? Using internal editor or not?

• reenter vfs

What do after this step?

Not only vfs doesn't get updated (as this had happened before too),

Yes, this is #62.

but now vfs can't be force-released from vfs dialog.

You just cannot release vfs forced if you make this within that vfs. You must leave vfs and then you can release it.

On a related note: I might be wrong here, but that dialog seems to be only one, that getting closed by Down Arrow - that's counter-intuitive and inconsistent.

"Right" key is an equivalent to "Enter" one, it moves you into selected vfs. Btw, this behavior exists more than 15 years.

[mc-butler]

Changed by mnk (galtgendo@….pl) on Jul 22, 2013 at 12:37 UTC (comment 2.3)

Replying to andrew_b:

Replying to mnk (#3045):

The workflow:

• create a patch
• enter vfs, delete a few files, leave vfs
• modify the patch externally (i.e. delete a single chunk from a file)

How? Using internal editor or not?

Usually using internal editor.

• reenter vfs

What do after this step?

Notice it's stale (or not and mess up the patch then). If notice, leave vfs and try to release it.

Not only vfs doesn't get updated (as this had happened before too),

Yes, this is #62.

but now vfs can't be force-released from vfs dialog.

You just cannot release vfs forced if you make this within that vfs. You must leave vfs and then you can release it.

Well, I thought it was obvious (from the context) I leave the vfs before releasing it.

On a related note: I might be wrong here, but that dialog seems to be only one, that getting closed by Down Arrow - that's counter-intuitive and inconsistent.

"Right" key is an equivalent to "Enter" one, it moves you into selected vfs. Btw, this behavior exists more than 15 years.

I've been using mc for a little over 10 years and this never became any less confusing and annoying.
What would be expected is something more alike to "Search Results" dialog, where Right Arrow moves the cursor to dialog's buttons.

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 22, 2013 at 13:06 UTC (comment 4)

I cannot reproduce this bug with recent master snapshot (4.8.9-4-g5fdd102) or I'm doing something wrong.

Would you try reproduce this bug with 4.8.9-4-g5fdd102 yourself?

[mc-butler]

Changed by mnk (galtgendo@….pl) on Jul 22, 2013 at 17:04 UTC (comment 5)

Well, I've just took [8cb80dc] and [4f1801c]
and the problem seems fixed (though links like changeset/[8cb80dc]?format=diff&new=[8cb80dc] save with \r\n endings - bit quirky).

Regardless of that, is the change of the inconsistent vfs dialog behavior open for discussion ?

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 23, 2013 at 12:24 UTC (comment 5.6)

• Status changed from new to accepted
• Component changed from mc-vfs to mc-core
• Branch state changed from no branch to on review
• Milestone changed from Future Releases to 4.8.10
• Owner set to andrew_b

Replying to mnk:

Regardless of that, is the change of the inconsistent vfs dialog behavior open for discussion ?

OK, this behavior is changed to be consistent with other dialogs.

Branch: 3045_hotlist_right_key.
[7d28512890a94e36b3e444d85bee0c4c542050f0]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Aug 1, 2013 at 9:19 UTC (comment 7)

• Votes set to angel_il

[mc-butler]

Changed by slavazanko (@slavaz) on Aug 1, 2013 at 13:58 UTC (comment 8)

• Votes changed from angel_il to angel_il slavazanko
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 1, 2013 at 18:26 UTC (comment 9)

• Resolution set to fixed
• Status changed from accepted to testing
• Votes changed from angel_il slavazanko to committed-master
• Branch state changed from approved to merged

Merged to master: [0eb1f6f].

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 1, 2013 at 18:32 UTC (comment 10)

• Status changed from testing to closed