Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of dir_list and related code #3066

Closed
mc-butler opened this issue Sep 2, 2013 · 5 comments
Closed

Refactoring of dir_list and related code #3066

mc-butler opened this issue Sep 2, 2013 · 5 comments
Assignees
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3066
Reporter andrew_b (@aborodin)
typedef struct
{
    file_entry *list;
    int size;
} dir_list;

The dir_list structure contains two members:

  • list -- the array of file_entry items
  • size -- number of allocated items in list (the capacity)

There is no member here which stored number of used elements in list. This info is kept outside dir_list (WPanel::count for reference). Actually, dir_list should have a member (len) to keep an actual length of list (number of used elements).

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 2, 2013 at 9:41 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.11
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Owner set to andrew_b

Branch: 3066_dir_list
Initial [96abc4b95231b39b82b84c5c183fadd9f82bf3ee]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Sep 9, 2013 at 20:29 UTC (comment 2)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 19, 2013 at 12:18 UTC (comment 3)

  • Branch state changed from on review to approved
  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 19, 2013 at 12:25 UTC (comment 4)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from approved to merged
  • Votes changed from slavazanko angel_il to committed-master

Merged to master: [cc980f3].

git log --pretty=oneline a339ad3..cc980f3

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 19, 2013 at 12:25 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants