"Search string not found" dialog inconsistencies

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3179
Reporter	egmont (@egmontkob)

Search for a string (with F7) that's not found.

In mcview, the dialog has the colors of a normal dialog, with whitespace above/below the "Search string not found" message and no button. Pressing any key closes the dialog.

In mcedit and in the diffviewer, the dialog has the colors of an error box, no vertical whitespace, but a separator line and a Dismiss button. Only space or enter close the dialog.

I believe these two should look and behave the same, or at least closer to each other than they currently do. I vote for normal dialog colors, I don't think it's an error if you search for something and it's not found. For the rest, I leave it up to you :)

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 14, 2014 at 6:08 UTC

• Milestone changed from Future Releases to 4.8.12
• Branch state changed from no branch to on review
• Status changed from new to accepted
• Owner set to andrew_b

Replying to egmont (#3179):

I vote for normal dialog colors, I don't think it's an error if you search for something and it's not found.

I agree.

Branch:3179_not_found_dialog_uniq
[a787608898b053b8d15a86084bb3b0cae1ec4af9]

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 17, 2014 at 12:54 UTC (comment 2)

• Votes set to slavazanko
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 18, 2014 at 17:13 UTC (comment 3)

• Branch state changed from approved to merged
• Resolution set to fixed
• Status changed from accepted to testing
• Votes changed from slavazanko to committed-master

Merged to master: [c8eb0f4].

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 18, 2014 at 17:14 UTC (comment 4)

• Status changed from testing to closed