GLib-CRITICAL **: g_queue_is_empty: assertion `queue != NULL' failed

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3223
Reporter	angel_il (@ilia-maslakov)

message "GLib-CRITICAL : g_queue_is_empty: assertion `queue != NULL' failed"
after mouse click in empty 'listbox'.

steps to reproduce:
1) menu Command\Directory hotlist (C-\)
2) listbox must be is empty
3) Rigt click in any place

trace

#0  listbox_event (event=0xbfffec60, data=0x8210058) at listbox.c:481
#1  0x08065e97 in dlg_mouse_event (event=0xbfffec60, h=0x820fec0) at dialog.c:398
#2  dlg_process_event (h=0x820fec0, key=-2, event=0xbfffec60) at dialog.c:1233
#3  0x080662cc in frontend_dlg_run (h=0x820fec0) at dialog.c:569
#4  dlg_run (h=0x820fec0) at dialog.c:1266
#5  0x0807a502 in hotlist_show (list_type=LIST_HOTLIST) at hotlist.c:1612
#6  0x0806079a in hotlist_cmd () at cmd.c:1214
#7  0x0808b87b in midnight_execute_cmd (sender=0x81f8328, command=58) at midnight.c:1294
#8  0x080bf2b2 in send_message (data=0x0, parm=<optimized out>, msg=MSG_ACTION, sender=0x81f8328, w=<optimized out>)
    at ../../lib/widget/widget-common.h:167
#9  menubar_execute (menubar=0x81f8328) at menu.c:341
#10 0x080bfe6b in menubar_event (data=0x81f8328, event=0xbfffee80) at menu.c:753
#11 menubar_event (event=0xbfffee80, data=0x81f8328) at menu.c:628
#12 0x08065e97 in dlg_mouse_event (event=0xbfffee80, h=0x81f7888) at dialog.c:398
#13 dlg_process_event (h=0x81f7888, key=-2, event=0xbfffee80) at dialog.c:1233
#14 0x080662cc in frontend_dlg_run (h=0x81f7888) at dialog.c:569
#15 dlg_run (h=0x81f7888) at dialog.c:1266
#16 0x0808d601 in create_panels_and_run_mc () at midnight.c:960
#17 do_nc () at midnight.c:1772
#18 0x0805384c in main (argc=1, argv=0xbffff0a4) at main.c:420
(gdb) print l
$1 = (WListbox *) 0x8210058
(gdb) print l->list 

$2 = (GQueue *) '''0x0'''

need check that l->list != NULL
in listbox.c line 481

481    if (g_queue_is_empty (l->list))

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jun 17, 2014 at 13:07 UTC (comment 1)

• Branch state changed from no branch to on review

branch: 3223_g_queue_fix

please review

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 26, 2014 at 6:11 UTC (comment 1.2)

Replying to angel_il:

3223_g_queue_fix

Fixed in 3189_cleanup.
Branch removed.

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 26, 2014 at 6:12 UTC (comment 3)

• Branch state changed from on review to no branch
• Blocked by set to #3189

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 22, 2014 at 9:15 UTC

• Blocked by #3189 deleted

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 22, 2014 at 9:16 UTC (comment 5)

• Status changed from new to closed
• Keywords listbox deleted
• Resolution set to fixed

Fixed as [478e58d].