mc compare directories (thorough) thinks empty files are different

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/350
Reporter	snizovtsev (@snizovtsev)
Keywords	commited-master

https://bugs.launchpad.net/ubuntu/+source/mc/+bug/181034
The bug was caused by mmap behaviour when length = 0. Here is quote from man(3) mmap:

SUSv3 specifies that mmap() should fail if length is 0. However, in kernels before 2.6.12, mmap() succeeded in this case: no mapping was created
and the call returned addr. Since kernel 2.6.12, mmap() fails with the error EINVAL for this case.

Note

Original attachments:

• fix_compare_on_empty_file.diff (raw) by snizovtsev (@snizovtsev) on May 11, 2009 at 13:53 UTC

[mc-butler]

Changed by snizovtsev (@snizovtsev) on May 11, 2009 at 13:53 UTC

• Attachment fix_compare_on_empty_file.diff (raw) added

[mc-butler]

Changed by snizovtsev (@snizovtsev) on May 11, 2009 at 16:06 UTC (comment 1)

• Milestone changed from 4.7 to 4.6.2.1
• Priority changed from major to trivial

[mc-butler]

Changed by slavazanko (@slavaz) on May 12, 2009 at 6:48 UTC (comment 2)

• Owner set to slavazanko
• Status changed from new to accepted
• Milestone changed from 4.6.2.1 to 4.7

[mc-butler]

Changed by slavazanko (@slavaz) on May 12, 2009 at 6:55 UTC (comment 3)

• Keywords set to review, vote-slavazanko

branch 350_compare_empty_files created(parent: master)

See [8c441fd]

My vote here.

[mc-butler]

Changed by styx (@styx) on May 13, 2009 at 10:32 UTC (comment 4)

• Keywords changed from review, vote-slavazanko to vote-slavazanko, vote-styx, approved

[mc-butler]

Changed by styx (@styx) on May 13, 2009 at 11:34 UTC (comment 5)

• Status changed from accepted to testing
• Resolution set to fixed

[mc-butler]

Changed by styx (@styx) on May 13, 2009 at 11:34 UTC (comment 6)

• Keywords changed from vote-slavazanko, vote-styx, approved to commited-master
• Status changed from testing to closed