[patch] fix /src/editor testsuite failure when ncurses is used

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3542
Reporter	and

fix /src/editor testsuite failure when ncurses is used

 Running suite /src/editor
 (null):-1:S:Core:test_autocomplete:0: (after this point) Received signal 11 (Segmentation fault)
 (null):-1:S:Core:test_autocomplete:1: (after this point) Received signal 11 (Segmentation fault)
 (null):-1:S:Core:test_autocomplete_single:0: (after this point) Received signal 11 (Segmentation fault)
 Results for all suites run:
 0%: Checks: 3, Failures: 0, Errors: 3

testsuite failed because ncurses:doupdate() called without proper init

 edit_init()
   -> edit_load_file()
      -> edit_load_file_fast()
         -> status_msg_init()
            -> mc_refesh()
               -> ncurses/tty_refresh()
                  -> doupdate()

patch against [52fd328]
compile test with GCC 5.2.0/ncurses 5.9

Signed-off-by: Andreas Mohr <​and@gmx.li>

Note

Original attachments:

• mc-3542-fix-editor-tests-segfault-on-ncurses.patch (raw) by and on Oct 21, 2015 at 22:42 UTC

[mc-butler]

Changed by and on Oct 21, 2015 at 22:42 UTC

• Attachment mc-3542-fix-editor-tests-segfault-on-ncurses.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 6, 2015 at 15:52 UTC (comment 1)

• Milestone changed from 4.8.15 to 4.8.16

[mc-butler]

Changed by zaytsev (@zyv) on Mar 5, 2016 at 22:18 UTC (comment 2)

• Milestone changed from 4.8.16 to 4.8.17

[mc-butler]

Changed by zaytsev (@zyv) on Apr 30, 2016 at 21:02 UTC (comment 3)

• Milestone changed from 4.8.17 to 4.8.18

[mc-butler]

Changed by zaytsev (@zyv) on Sep 22, 2016 at 18:49 UTC (comment 4)

• Milestone changed from 4.8.18 to 4.8.19

[mc-butler]

Changed by zaytsev (@zyv) on Nov 18, 2017 at 17:34 UTC (comment 5)

• Milestone changed from 4.8.20 to 4.8.21

[mc-butler]

Changed by zaytsev (@zyv) on May 27, 2018 at 12:30 UTC (comment 6)

• Milestone changed from 4.8.21 to 4.8.22

[mc-butler]

Changed by zaytsev (@zyv) on Dec 29, 2018 at 14:53 UTC (comment 7)

• Milestone changed from 4.8.22 to 4.8.23

[mc-butler]

Changed by zaytsev (@zyv) on Jun 16, 2019 at 17:22 UTC (comment 8)

• Milestone changed from 4.8.23 to 4.8.24

[mc-butler]

Changed by zaytsev (@zyv) on Jul 5, 2020 at 17:31 UTC (comment 9)

• Milestone changed from 4.8.25 to 4.8.26

[mc-butler]

Changed by zaytsev (@zyv) on Jan 10, 2021 at 14:26 UTC (comment 10)

• Milestone changed from 4.8.26 to 4.8.27

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 8, 2021 at 6:24 UTC (comment 11)

• Milestone changed from 4.8.27 to Future Releases

[mc-butler]

Changed by zaytsev (@zyv) on Sep 3, 2024 at 8:08 UTC (comment 12)

• Status changed from new to accepted
• Owner set to zaytsev

This bug is due to mc_refresh mock not being called and instead a real function being called instead. It will be fixed if mocking is generally fixed in tests.

[mc-butler]

Changed by zaytsev (@zyv) on Sep 10, 2024 at 8:42 UTC (comment 13)

• Blocked by set to #4584

[mc-butler]

Changed by zaytsev (@zyv) on Oct 19, 2024 at 7:09 UTC (comment 14)

• Component changed from mc-core to tests
• Status changed from accepted to testing
• Resolution set to fixed
• Milestone changed from Future Releases to 4.8.33

This should be now fixed in #4584.

[mc-butler]

Changed by zaytsev (@zyv) on Oct 20, 2024 at 11:20 UTC (comment 15)

• Status changed from testing to closed

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:27 UTC (comment 16)

• Blocked by changed from #4584 to #4170