Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release mc-4.8.16 #3547

Closed
mc-butler opened this issue Nov 8, 2015 · 137 comments
Closed

Prepare for release mc-4.8.16 #3547

mc-butler opened this issue Nov 8, 2015 · 137 comments
Assignees
@zyv
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.16

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3547
Reporter zaytsev (@zyv)
Mentions egmont (@egmontkob)

See ReleaseGuidelines for more details.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on Nov 8, 2015 at 20:09 UTC (comment 1)

  • Cc set to egmont

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 10, 2015 at 13:04 UTC (comment 2)

JFYI: The branch 3547_cleanup has been created for the ticket

@mc-butler
Copy link
Author

Changed by zaytsev-work (@zyv) on Nov 10, 2015 at 16:11 UTC (comment 3)

FIXFOR Ticket #3547: move subshell stuff into subdir.

src/subshell/common.c

-Vit Rosin <​vit_r@list.ru
+Vit Rosin <​vit_r@list.ru>

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 13, 2015 at 15:13 UTC

(In #3555) No reason for special ticket. Use #3547 instead.

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 18:36 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 18:36 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 18:36 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 18:39 UTC (comment 5)

next cleanup patches attached, let me know if this ticket is right for cleanup patch requests

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 14, 2015 at 18:51 UTC (comment 6)

This ticket is the right one, thanks!

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 19:07 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 19:40 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 14, 2015 at 23:44 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 15, 2015 at 9:48 UTC (comment 7)

mc-3547-cleanup-conversion-warning-lock_c.patch: applied with additional changes.

mc-3547-cleanup-conversion-warning-keybind_t.patch
I'd prefer to make command of (signed) long type not int.

mc-3547-cleanup-conversion-warning-strutils_escape.patch

remove src_len parameter support, never used in mc

The another way should be found. I think we shouldn't introduce any limitation in library code. Currently source string length is not used, but who knows about future?

mc-3547-cleanup-conversion-warning-mc_search_new.patch: applied with some changes.

@mc-butler
Copy link
Author

Changed by and on Nov 15, 2015 at 15:05 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 15, 2015 at 15:05 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 15, 2015 at 15:05 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 15, 2015 at 17:07 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 15, 2015 at 17:19 UTC (comment 8)

mc-3547-cleanup-conversion-warning-gauge_c.patch: applied.

mc-3547-cleanup-conversion-warning-menubar_selected.patch: WMenubar related part is applied, editor menu is fixed with another way.

Andreas, it would be great if you create your patches using git format-patch command. Thanks!

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 15, 2015 at 19:01 UTC (comment 9)

Trivial doc patch in #3556 can be committed upon review.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 16, 2015 at 6:30 UTC (comment 10)

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 16, 2015 at 6:34 UTC (comment 11)

Check that one can do update-po on the tarballs before the next release (#3553).

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 17, 2015 at 21:44 UTC

@mc-butler
Copy link
Author

Changed by and on Nov 20, 2015 at 21:16 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 21, 2015 at 14:53 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 21, 2015 at 14:53 UTC (comment 13)

mc-3547-cleanup-conversion-warning-chown_advanced_but.patch: applied
mc-3547-cleanup-conversion-warning-chown_but.patch​: applied
mc-3547-cleanup-conversion-warning-chmod_but.patch​: applied
mc-3547-cleanup-conversion-warning-mode_t.patch: applied
mc-3547-remove-outdated-comment-about-refresh.patch​: applied
mc-3547-fix-compiler-warning-at-search.c.patch: applied

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 21, 2015 at 15:17 UTC (comment 7.14)

Replying to andrew_b:

mc-3547-cleanup-conversion-warning-keybind_t.patch
I'd prefer to make command of (signed) long type not int.

Done.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 21, 2015 at 22:02 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 22, 2015 at 14:10 UTC (comment 15)

mc-3547-listbox.c-remove-redundant-code.patch​: applied.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 24, 2015 at 17:26 UTC (comment 16)

@andreas:

I'm curious about how you work: let's say you've just edited the source code to fix some compiler warnings -- what are you doing next?

@mc-butler
Copy link
Author

Changed by and on Nov 24, 2015 at 18:19 UTC (comment 16.17)

Replying to mooffie:

@andreas:

I'm curious about how you work: let's say you've just edited the source code to fix some compiler warnings -- what are you doing next?

Is this a criticism (which intention) or a question about work flow? :)

If we don't care about "valid" compiler warnings, we are not worthy for portable code.

Further, let's assume you are a package maintainer at a distribution and wan't annex mc. First thing you do are pedantic compile runs to get a basic view about code quality

I like to see solving -Wformat-nonliteral completely
maybe full -Wconversion fixing is not possible because of gnome inconsistent

finding/fixing memleaks should be valuable, you can help out while running mc with
-fsanitize=*

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Feb 23, 2016 at 16:49 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 23, 2016 at 18:17 UTC (comment 71)

mc-3547-WPanel-should-report-MSG_NOT_HANDLED-for-unhandled-commands.patch​: applied.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 27, 2016 at 7:00 UTC (comment 72)

Rebased to current master.
Initial commit: [2b6c45a].
Please review.

TODO: update po/mc.pot and po/*.po after merge.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 27, 2016 at 7:06 UTC (comment 73)

  • Branch state changed from no branch to on review

@mc-butler
Copy link
Author

Changed by and on Feb 27, 2016 at 22:53 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 27, 2016 at 23:42 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 0:18 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 28, 2016 at 7:31 UTC (comment 74)

mc-3547-cleanup-Wlogical-not-parentheses-warning.patch​: applied
mc-3547-cleanup-Wconditional-uninitialized-warning.patch​: applied
mc-3547-cleanup-Wfloat-conversion-warning.patch​: applied.

@and: Andreas, please use a capital letter to begin a sentence in a patch comment. Thanks.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 28, 2016 at 21:09 UTC (comment 75)

Re. review: I will try to have a look next weekend!

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 23:00 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 23:00 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 23:00 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 23:00 UTC

@mc-butler
Copy link
Author

Changed by and on Feb 28, 2016 at 23:00 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 2, 2016 at 7:25 UTC (comment 76)

mc-3547-src-editor-edit.c-Cleanup-some-compiler-warnings.patch​: applied.
mc-3547-src-editor-editbuffer.c-Cleanup-some-Warnings.patch​: applied with some changes and additions.
mc-3547-src-editor-editwidget.c-Cleanup-some-compiler-warnin.patch​: applied.
mc-3547-src-editor-etags.c-Cleanup-some-compiler-warnings.patch​: another fix.
mc-3547-widget_options_t-Cleanup-Wassign-enum-warnings.patch​: applied with rename W_NONE -> W_DEFAULT with value 0.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 3, 2016 at 21:16 UTC (comment 77)

  • Votes set to zaytsev

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 4, 2016 at 6:30 UTC (comment 78)

  • Branch state changed from on review to approved
  • Votes changed from zaytsev to zaytsev andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 4, 2016 at 6:32 UTC (comment 79)

  • Votes changed from zaytsev andrew_b to committed-master
  • Branch state changed from approved to merged

Merged to master: [e8b68df].

git log --pretty=oneline 10a1c9d..e8b68df

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 4, 2016 at 6:34 UTC (comment 80)

  • Votes committed-master deleted
  • Branch state changed from merged to no branch

That's all. Other cleanups welcome to next release.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 4, 2016 at 6:37 UTC (comment 81)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 4, 2016 at 6:38 UTC

  • Blocked by set to #3553

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 16:45 UTC (comment 83)

download PO-translations from Transifex.net

done; [eae2a25]

download the hint translations from Transifex.net

done; [e527269]

create new NEWS wiki page for next version with empty template

done; wiki:NEWS-4.8.17

add content of current NEWS wiki page to the doc/NEWS file in git repo

done; [4e71328]

create new tag in git

done

new version in Trac

done

new milestone in Trac

done

create tar.(bz2|xz) package files

done

make checksums for archives

done

c37ea495df93f6d375a3ce59cdcf0f3a3690338526205347b03a316daebdaaf8  mc-4.8.16.tar.bz2
bbbcbe3097d3160f865d24aa38ff122f1c59752b5ef153ca4ade5ac0f82b7020  mc-4.8.16.tar.xz

upload source packages and checksums to the special upload area

done; ​https://www.midnight-commander.org/nopaste/tarball/

developers should download tarballs, verify checksums, compile and install locally; if everything is ok, then developers vote for the ticket

done; please check it out!

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 16:46 UTC (comment 84)

  • Branch state changed from no branch to on review
  • Owner set to zaytsev
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 17:48 UTC

  • Blocked by #3553 deleted

(In #3553) I've checked it with the new release tarball that I've just generated and it seems to work fine now.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 12, 2016 at 17:51 UTC (comment 86)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 21:21 UTC (comment 87)

  • Branch state changed from on review to approved
  • Resolution set to fixed
  • Status changed from accepted to testing

upload source packages and checksums to ​​midnightcommander@ftp-osl.osuosl.org

done

run command: ssh ​midnightcommander@ftp-osl.osuosl.org '/home/midnightcommander/trigger-midnightcommander'

done

update Wiki start page with latest release number

done

write an announcement: list user visible changes (bugs and features)

done

create new ticket (type=task, component=adm) for the next release

done; #3607

close current milestone

done

close ticket for release

done

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 21:22 UTC (comment 88)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyv zyv

Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.16
Development

No branches or pull requests
2 participants
@zyv @mc-butler