Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] extfs.c: fix buffer overflow #3605

Closed
mc-butler opened this issue Mar 12, 2016 · 6 comments
Closed

[patch] extfs.c: fix buffer overflow #3605

mc-butler opened this issue Mar 12, 2016 · 6 comments
Assignees
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3605
Reporter and

When handling with copy/move commands inside of archive we can lead into buffer overflow
steps to roproduce:

create simple 7z archive
open it
rename single filename
hit buffer overflow

found by clang/AddressSanitizer

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by and on Mar 12, 2016 at 16:32 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 12, 2016 at 21:25 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.17

It would be great if you would attach tickets with fresh patches ready for review to the current milestone. Otherwise, I'm afraid, they will get lost among other hundreds of tickets. If we can't make it for this milestone, we can always move it to the next one. Thanks!

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 20, 2016 at 8:57 UTC (comment 2)

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Component changed from mc-core to mc-vfs

Branch:3605_extfs_buffer_overflow
[e1ad66e]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 20, 2016 at 8:59 UTC (comment 3)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 20, 2016 at 9:00 UTC (comment 4)

  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master
  • Status changed from accepted to testing
  • Branch state changed from approved to merged

Merged to master: [d6f0317].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 20, 2016 at 9:01 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants