Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release mc-4.8.17 #3607

Closed
mc-butler opened this issue Mar 12, 2016 · 36 comments
Closed

Prepare for release mc-4.8.17 #3607

mc-butler opened this issue Mar 12, 2016 · 36 comments
Assignees
@zyv
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.17

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3607
Reporter zaytsev (@zyv)

See wiki:ReleaseGuidelines for more details.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 13, 2016 at 6:32 UTC (comment 1)

Branch: 3607_cleanup.
Initial [a817c4635eca4a819ab254e53668343c34eb4bcb]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 15, 2016 at 6:45 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 15, 2016 at 18:51 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 15, 2016 at 19:37 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Mar 16, 2016 at 17:28 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Mar 16, 2016 at 17:33 UTC (comment 3)

(As for the patch I've just attached (S-Lang title at configure's summary): it's a little silly to have the duplicate "library" word in "Screen library: S-Lang library" and "Screen library: Ncurses library". If you want me to remove the second "library" word, let me know.)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 19, 2016 at 8:01 UTC (comment 4)

mc-3607-args.c-Make-solaris-studio-happy.patch​: applied.
mc-3607-widget-dialog.c-Make-Solaris-Studio-happy.patch​: applied.
mc-3607-configure-summary-omits-S-Lang-when-used-as-screen-library.patch​: applied.
Text of screen_msg was fixed in separate commit.

@mc-butler
Copy link
Author

Changed by and on Mar 19, 2016 at 14:51 UTC (comment 5)

Hi Andrew, Yuri,
I setup a Open Build Service testing for mc at build.opensuse.org

https://build.opensuse.org/package/show/home:andreasmohr:mc/mc-git_master-ncurses

(SuSE/RedHat spec/rpm and Arch/pkgbuild was easy mode but depian drying old build concept is nappy)

As first step I choose explicit ncurses+libssh2+libgpm+enable-werror
and take git(hub) master source.

fun fact, older(!) gcc version (RHEL6) inform us about:

[  130s] widget-common.c: In function 'mouse_get_local':
[  130s] widget-common.c:369: error: 'local.margin' is used uninitialized in this function [-Wuninitialized]
[  130s] widget-common.c:369: error: 'local.clicks' is used uninitialized in this function [-Wuninitialized]
[  130s] widget-common.c:369: error: 'local.vc' is used uninitialized in this function [-Wuninitialized]

I will create more build tests (slang,minimal,different git brand source?).
Let me know, what should be next and for interest.

@mc-butler
Copy link
Author

Changed by and on Mar 19, 2016 at 18:39 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 19, 2016 at 18:54 UTC (comment 6)

I have rework package naming for better future permutation testing.

https://build.opensuse.org/project/show/home:andreasmohr:mc

@mc-butler
Copy link
Author

Changed by and on Mar 21, 2016 at 18:45 UTC (comment 7)

Consider to take #3598 into this cleanup round and skip all g_strdup patches for now.

@mc-butler
Copy link
Author

Changed by and on Mar 22, 2016 at 19:54 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 26, 2016 at 0:33 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 26, 2016 at 16:59 UTC (comment 8)

mc-3607-widget-common.c-Cleanup-uninitialized-warning.patch​: applied.
mc-3607-cppcheck-Cleanup-Passing-NULL-after-the-last-warning.patch​: applied.

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Mar 31, 2016 at 23:33 UTC (comment 9)

Commit "(input_is_empty): new WInput API" has a mistake:

In input_is_empty(), it should be "== '\0'", not "!= '\0'".

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 1, 2016 at 5:47 UTC (comment 9.10)

Replying to mooffie:

Commit "(input_is_empty): new WInput API" has a mistake:

In input_is_empty(), it should be "== '\0'", not "!= '\0'".

Fixed. Thanks.
The code in input_is_empty() is overcareful, but let it be.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 7, 2016 at 7:56 UTC (comment 11)

mc-3607-Remove-orphaned-be-tarask.po_-file.patch: applied.

@mc-butler
Copy link
Author

Changed by and on Apr 24, 2016 at 20:43 UTC

@mc-butler
Copy link
Author

Changed by and on Apr 24, 2016 at 20:44 UTC

@mc-butler
Copy link
Author

Changed by and on Apr 24, 2016 at 21:05 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 25, 2016 at 7:54 UTC (comment 12)

mc-3607-cleanup-cppcheck-warning-at-direntry.patch​: applied.
mc-3607-cleanup-cppcheck-warning-at-layout.patch​: applied.
mc-3607-cleanup-cppcheck-warning-at-utilunix.patch​: applied.

@mc-butler
Copy link
Author

Changed by and on Apr 28, 2016 at 16:39 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 29, 2016 at 9:47 UTC (comment 13)

3607-Cleanup-cppcheck-warning-at-input_complete.patch​: applied.

@mc-butler
Copy link
Author

Changed by zaytsev-work (@zyv) on Apr 29, 2016 at 13:10 UTC (comment 14)

Hi Andrew, would you be so kind as to rebase against master? I'll try my best to have a deeper look during the weekend, as discussed. Thanks!

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 29, 2016 at 15:46 UTC (comment 14.15)

Done.
Initial [2f3a10ece140acaa196280db144ae9bb00b26b53]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 1, 2016 at 7:33 UTC (comment 16)

Sync with gnulib just caused:

../../../lib/strutil/xstrtol.c: In function ‘xstrtoumax’:
../../../lib/strutil/xstrtol.c:145:9: error: switch missing default case [-Werror=switch-default]

@mc-butler
Copy link
Author

Changed by and on May 1, 2016 at 19:09 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 6, 2016 at 11:18 UTC (comment 17)

  • Branch state changed from no branch to on review

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 7, 2016 at 12:58 UTC (comment 18)

  • Branch state changed from on review to approved
  • Status changed from new to accepted
  • Owner set to zaytsev

I've looked at the patches, and it seems reasonable. Too bad we don't have a robust safety net for refactorings as in [52263429b3601272ec255f7568ec2e5b0f18ee48]. Apart from that, I've applied the last patch by Andreas, and added a few file formats to filehighlight.

Are we good to go for the release tomorrow? I will try to have a look at #3130 after lunch.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 7, 2016 at 13:25 UTC (comment 19)

  • Branch state changed from approved to merged
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master: [82fc95f].

git log --pretty=oneline 7fd0f17..82fc95f

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 7, 2016 at 13:26 UTC (comment 20)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 7, 2016 at 14:19 UTC (comment 21)

  • Resolution fixed deleted
  • Status changed from closed to reopened

Huh, that's the release ticket, right?

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 7, 2016 at 16:22 UTC (comment 22)

download PO-translations from Transifex.net

done

store translations in git repo

done

download the hint translations from Transifex.net

done

store translations in git repo

not necessary

create new NEWS wiki page for next version with empty template

done (wiki:NEWS-4.8.17)

add content of current NEWS wiki page to the doc/NEWS file

done

create new tag in git

done; not pushed yet

new version in Trac

done

new milestone in Trac

done

create tar.(bz2|xz) package files

done

make checksums for archives

done

upload source packages and checksums to the special upload area

done

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 7, 2016 at 16:32 UTC (comment 23)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 7, 2016 at 16:35 UTC (comment 24)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 8, 2016 at 10:03 UTC (comment 25)

  • Status changed from reopened to closed
  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed

developers should download tarballs, verify checksums, compile and install locally

done

upload source packages and checksums ...

done

run command: ...

done

update Wiki start page with latest release number

done

write an announcement: list user visible changes (bugs and features)

done

close current milestone

done

create new ticket (type=task, component=adm) for the next release

done; #3641

close ticket for release

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyv zyv

Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone
4.8.17
Development

No branches or pull requests
2 participants
@zyv @mc-butler