Hide editor private API

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/361
Reporter	andrew_b (@aborodin)

Currently, edit/edit.h contains a lot of declarations (functions defines, types, variables), but most of them are used internally in editor. Just several functions are used in MC core. So there is a reason to move all editor-private stuff to edit/edit-impl.h header and edit/edit.h header will be contain the public editor API only.

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 14, 2009 at 15:27 UTC (comment 1)

• Keywords set to review
• Owner set to andrew_b
• Version changed from 4.6.2 to master
• Status changed from new to accepted

Created 361_editor_public_api branch. Parent branch:master.
Initial [5a7cc515bc1d28ddd05f5df224b516f079cc773f]

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 15, 2009 at 16:41 UTC (comment 2)

Added missed file.
Rebased to master.
[e786322c15bbbf4b4c60501058f6ce749a0164c8]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jun 16, 2009 at 5:38 UTC (comment 3)

• Keywords changed from review to review, vote-angel_il

[mc-butler]

Changed by styx (@styx) on Jun 16, 2009 at 10:40 UTC (comment 4)

• Keywords changed from review, vote-angel_il to vote-angel_il, vote-styx, approved

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 16, 2009 at 11:41 UTC (comment 5)

• Resolution set to fixed
• Keywords changed from vote-angel_il, vote-styx, approved to commited-master
• Status changed from accepted to testing

Merged to master.

Start [fd09aba]
End [3337c39]

git log --pretty=oneline fd09aba^..3337c39

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 16, 2009 at 11:42 UTC (comment 6)

• Status changed from testing to closed

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 28, 2009 at 5:02 UTC (comment 7)

• Priority changed from minor to major
• Milestone changed from 4.7 to 4.7.0-pre1
• Status changed from closed to reopened
• Keywords commited-master deleted
• Severity set to no branch
• Type changed from task to defect
• Resolution fixed deleted

Gabor Z. Papp <gzp at papp dot hu> reports that mc cannot be built with --without-edit option.

user.o: In function `expand_format':
/home/gzp/src/mc/src/user.c:190: undefined reference to `edit_get_file_name'
/home/gzp/src/mc/src/user.c:235: undefined reference to `edit_get_curs_col'
/home/gzp/src/mc/src/user.c:239: undefined reference to `edit_get_syntax_type'
user.o: In function `test_condition':
/home/gzp/src/mc/src/user.c:442: undefined reference to `edit_get_syntax_type'
collect2: ld returned 1 exit status

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 28, 2009 at 6:53 UTC (comment 7.8)

• Component changed from mcedit to mc-core
• Severity changed from no branch to on review

Created 361_without_edit branch. Parent branch: master.
[264a87697fa5a5cfce7032509d73235f1949ee6a]

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 28, 2009 at 17:20 UTC (comment 9)

• Votes set to angel_il

[mc-butler]

Changed by iNode (@iNode) on Jul 29, 2009 at 10:05 UTC (comment 10)

• Severity changed from on review to approved
• Votes changed from angel_il to angel_il iNode

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 29, 2009 at 10:18 UTC (comment 11)

• Severity changed from approved to merged
• Votes changed from angel_il iNode to commited-master
• Resolution set to fixed
• Status changed from reopened to closed

Merged to master.
[d49a378]