-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes behaves differently with TERM=xterm-256color #3626
Comments
|
I too don't like this behavior (it's by design (#2169), not a bug), which is why I'm not using xterm-256color.
In modern distros (at least Ubuntu) TERM is "xterm-256color" by default. Add to this the fact that prevalent terminal palettes don't have enough contrast between "white" and "lightgrey" (or is it "grey") and you get a usability problem "out of the box". |
Is it not a rendering bug in the terminal emulator? I use vte and my TERM is xterm-256color, and with Droid fonts, which have a real (not faux) bold versions the directories are correctly rendered bold. |
According to original 256c support commit, referenced by @mooffie, lack of bold is an intended behavior. Unfortunately original commiter mistakenly assumed that everybody treat colors the same and that was a strategic mistake.
@zaytsev, regarding the Droid font.
As a quick and simple solution, I suggest disabling 256c mode unless current theme does declare support for it. Fortunately we have "[skin]::256colors = true" for that.
What do you think? |
|
@eugenesan, I've just attached a screenshot of mc under Ubuntu 14.04 with the default (Ubuntu) fonts, TERM=xterm-256color and modarin256-defbg skin in gnome-terminal (vte). Can you explain me what's wrong here? The directories are as bold as it gets. |
Replying to zaytsev-work:
Note the ";bold".
Most other skins, notably the default one (skins/default.ini), don't specify ";bold" explicitly and therefore aren't displaying bold in 256 mode.
What @eugenesan suggests is to have, as in the old days, the 8 high-intensity colors ("white", "brightgreen", "brightred", "yellow", ...) be bold by default when not using a 256 colors skin, at least. (I say "at least" because people may want to have them bold even when a 256 skin is active: because of the editor syntax files, or because they simply prefer bold.)
(For the record: one solution that doesn't involve coding is to to add ";bold" explicitly to all "directory=" lines. But we use high-intensity colors in other places too ("executable=", syntax files).) |
I'm attaching a screenshot that shows what a new user sees on Lubuntu (a sort of Ubuntu). That's gnome-terminal. Note how (when in 256 colors, default skin) it's not easy to distinguish between directories and normal files.
Replying to mooffie:
(I now see that setting TERM to "xterm-256color" is, probably, the work of gnome-terminal itself.) |
|
Dup of #3048. |
Important
This issue was migrated from Trac:
eugenesan
(eugenesan@….com)Themes behaves differently with TERM=xterm-256color.
For example folders and execuables are not displayed using bold.
Starting with "TERM=xterm mc" solves the problem.
Note
Original attachments:
zaytsev-work
(@zyv) onMar 30, 2016 at 7:24 UTC
mooffie
(@mooffie) onMar 30, 2016 at 10:40 UTC
The text was updated successfully, but these errors were encountered: