Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop tests for embedded scripts, e.g. VFS #3636

Closed
mc-butler opened this issue Apr 21, 2016 · 5 comments
Closed

Develop tests for embedded scripts, e.g. VFS #3636

mc-butler opened this issue Apr 21, 2016 · 5 comments
Assignees
@mooffie
Labels
area: tests Testing Midnight Commander prio: medium Has the potential to affect progress res: invalid The ticket is not a bug, or is a support request

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3636
Reporter zaytsev (@zyv)

It would be great if we could at least syntax check embedded Perl and Python scripts. Otherwise, they get broken by typos and bad merges without anyone noticing.

See #3620 for the details.
@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 23, 2016 at 14:03 UTC (comment 1)

The aim of this ticket is too general: What kind of tests? -syntax check?
-functionality? What scripts? -extfs? -FISH? -others?

So I suggest to mark it a dup of:

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 29, 2017 at 21:32 UTC (comment 2)

  • Owner set to mooffie
  • Status changed from new to assigned

What I had in mind when opening this ticket was to add a test that simply runs something like perl -wc on anything we have in terms of Perl scripts in the repository, and this will cover a little bit of everything, like parts of extfs written in Perl, some FISH stuff, etc.

Now, thanks to your excellent work, at least the most dangerous and error-prone part of extfs scripts can now be tested (file listing), and is actually tested for several scripts, irrespectively of the language in which they are written. You are right that there is a separate ticket that I filed for FISH stuff, after the bug fixing fiasco. The Perl scripts that remain are probably not worth extra effort.

Please feel free to close this ticket as wontfix or something...

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 3, 2024 at 5:55 UTC (comment 3)

  • Resolution set to invalid
  • Status changed from assigned to testing
  • Milestone Future Releases deleted

This ticket is not specific enough, and we've got enough unspecific tickets already. VFS scripts are somewhat covered, FISH scripts are not, but ticket exists. So I will close this as invalid.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 3, 2024 at 5:56 UTC (comment 4)

  • Version master deleted

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 3, 2024 at 5:56 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mooffie mooffie

Labels
area: tests Testing Midnight Commander prio: medium Has the potential to affect progress res: invalid The ticket is not a bug, or is a support request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mooffie @mc-butler