Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release mc-4.8.18 #3641

Closed
mc-butler opened this issue May 8, 2016 · 46 comments
Closed

Prepare for release mc-4.8.18 #3641

mc-butler opened this issue May 8, 2016 · 46 comments
Assignees
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3641
Reporter zaytsev (@zyv)
Mentions egmont (@egmontkob)

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by egmont (@egmontkob) on May 8, 2016 at 21:27 UTC (comment 1)

  • Cc set to egmont

@mc-butler
Copy link
Author

Changed by and on May 22, 2016 at 0:07 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 22, 2016 at 11:38 UTC (comment 2)

Branch: 3641_cleanup.
Initial [6e28886905541b431ab87997636089bfdb9cb4d3]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 22, 2016 at 11:39 UTC (comment 3)

mc-3641-cleanup-Wconditional-uninitialized-at-input_complete.patch​: applied.

@mc-butler
Copy link
Author

Changed by and on May 28, 2016 at 10:07 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 8, 2016 at 11:50 UTC (comment 4)

mc-3641-cleanup-compile-warning-for-mc_search.patch: applied.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 8, 2016 at 11:51 UTC

(In #3652) Applied with some modifications in 3641_cleanup branch.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 4, 2016 at 6:10 UTC (comment 6)

  • Branch state changed from no branch to on review

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 14, 2016 at 4:08 UTC (comment 7)

Hi Andrew!

I'm attaching a minor patch. Node.js is quite a buzz nowadays.

(I needed a ruse to chime in! You're doing a terrific job. Thanks for fixing the "long panel listing" mouse bug. I'm sorry for being AWOL the last couple of months: a computer crash I'm still reeling from took its toll.)

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Jul 14, 2016 at 4:11 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 16, 2016 at 6:45 UTC (comment 7.8)

Replying to mooffie:

I'm attaching a minor patch. Node.js is quite a buzz nowadays.

Applied. Thanks!

@mc-butler
Copy link
Author

Changed by and on Jul 16, 2016 at 23:06 UTC

@mc-butler
Copy link
Author

Changed by and on Jul 16, 2016 at 23:06 UTC

@mc-butler
Copy link
Author

Changed by and on Jul 16, 2016 at 23:06 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 17, 2016 at 9:19 UTC (comment 9)

mc-3641-cleanup-compile-warning-glob_c.patch​: applied.
mc-3641-cleanup-compile-warning-unused_macro.patch​: applied.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 18, 2016 at 6:13 UTC (comment 10)

About mc-3641-cleanup-compile-warning-background_c.patch​.
On x86_64:

$ LC_ALL=C mc -V | tail -1
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

As you can see, the bitwidths of int and size_t are different. I'm not sure that change of type form int to size_t in the following case

write (parent_fd, &len, sizeof (len));

(write 4 bytes instead of 2) is correct.

Upd: sorry, 8 bytes instead of 4, of course.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 29, 2016 at 6:34 UTC (comment 11)

  • Votes set to committed-master
  • Branch state changed from on review to merged

Merged to master: [7767762].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 29, 2016 at 6:35 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 8, 2016 at 7:23 UTC (comment 13)

Branch: 3641_cleanup
Initial changeset: [4ddcefc8df7fde92a26abb1b4effe9b91471b087]

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Sep 7, 2016 at 22:30 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Sep 7, 2016 at 22:31 UTC (comment 14)

(That last patch contains a commit message explaining it.)

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Sep 8, 2016 at 14:25 UTC

(See commit message. This is a followup to my previous patch.)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 11, 2016 at 8:15 UTC (comment 15)

  • Resolution set to fixed
  • Status changed from new to closed

mc-3641-cleanup-paths_c.patch​: applied.
mc-3641-paths.c-reduce-scope-of-homedir-var.patch: applied.

Merged to master: [74dda73].

git log --pretty=oneline 834c09a..74dda73

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 11, 2016 at 8:16 UTC (comment 16)

  • Resolution fixed deleted
  • Status changed from closed to reopened

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:23 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:24 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:25 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:25 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 13:42 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 22:16 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 22:16 UTC

@mc-butler
Copy link
Author

Changed by and on Sep 17, 2016 at 22:16 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 25, 2016 at 19:59 UTC (comment 17)

Created #3693 for further cleanup patches.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 26, 2016 at 7:49 UTC (comment 18)

mc-3641-cleanup-Wformat-signedness-common_c.patch​
mc-3641-cleanup-Wformat-signedness-editdraw_c.patch
mc-3641-cleanup-Wformat-signedness-file_c.patch
mc-3641-cleanup-Wformat-signedness-find_c.patch​
mc-3641-cleanup-Wformat-signedness-ftpfs_c.patch
mc-3641-cleanup-Wformat-signedness-hex_c.patch​
mc-3641-cleanup-Wformat-signedness-info_c.patch
mc-3641-cleanup-Wformat-signedness-midnight_c.patch
mc-3641-cleanup-Wformat-signedness-path_c.patch​
mc-3641-cleanup-Wformat-signedness-serialize_c.patch
mc-3641-cleanup-Wunsafe-loop-optimizations.patch​
mc-3641-cleanup-no-attribute-noreturn-utilunix.c.patch
mc-3641-cleanup-no-attribute-noreturn-utilvfs.c.patch
mc-3641-cleanup-unreachable-code-warning-utilunix_c.patch

were copied to #3693.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 2, 2016 at 17:53 UTC (comment 19)

download PO-translations from Transifex.net

done

store translations in git repo

done

download the hint translations from Transifex.net

done

store translations in git repo

done

create new NEWS wiki page for next version

done (wiki:NEWS-4.8.19)

add content of current NEWS wiki page to the doc/NEWS

done

create new tag in git

done; not pushed yet

new version in Trac

done

new milestone in Trac

done

create tar.(bz2|xz) package files

done

make checksums for archives

done

upload source packages and checksums to the special upload area

done

developers should download tarballs, verify checksums, compile and install locally; if everything is ok, then developers vote for the ticket

...

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 2, 2016 at 17:55 UTC (comment 20)

  • Status changed from reopened to accepted
  • Branch state changed from merged to approved
  • Owner set to zaytsev
  • Votes committed-master deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 2, 2016 at 18:15 UTC (comment 21)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 2, 2016 at 19:21 UTC (comment 22)

  • Status changed from accepted to testing
  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

upload source packages and checksums

done

run command: ...

done

update Wiki start page with latest release number

done

write an announcement

done

close current milestone

done

create new ticket (type=task, component=adm) for the next release

done; #3693

close ticket for release

done

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 8, 2016 at 9:00 UTC (comment 23)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 8, 2016 at 9:01 UTC (comment 24)

  • Milestone changed from 4.8.19 to 4.8.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: adm Administrative tasks prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants