mc-4.8.17 failing to build on FreeBSD

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3643
Reporter	woodsb02 (woodsb02@….com)

The latest release of mc 4.8.17 fails to build on FreeBSD with the following error:

  CCLD     mc
./.libs/libinternal.a(cons.handler.o): In function `show_console_contents':
cons.handler.c:(.text+0x98): undefined reference to `min'
cons.handler.c:(.text+0xde): undefined reference to `min'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:658: recipe for target 'mc' failed

Note

Original attachments:

• mc-4.8.17.log (raw) by woodsb02 (woodsb02@….com) on May 11, 2016 at 10:00 UTC
• patch-src_cons.handler.c (raw) by woodsb02 (woodsb02@….com) on May 11, 2016 at 10:03 UTC

[mc-butler]

Changed by woodsb02 (woodsb02@….com) on May 11, 2016 at 10:00 UTC

• Attachment mc-4.8.17.log (raw) added

Failing build log of mc 4.8.17 on FreeBSD 11-current

[mc-butler]

Changed by woodsb02 (woodsb02@….com) on May 11, 2016 at 10:03 UTC

• Attachment patch-src_cons.handler.c (raw) added

Patch to fix build of mc 4.8.17 on FreeBSD (replace min with MIN in src/cons.handler.c)

[mc-butler]

Changed by zaytsev (@zyv) on May 11, 2016 at 19:24 UTC (comment 1)

• Status changed from new to accepted
• Owner set to zaytsev
• Milestone changed from Future Releases to 4.8.18

[mc-butler]

Changed by zaytsev (@zyv) on May 11, 2016 at 19:37 UTC (comment 2)

• Branch state changed from no branch to on review

Branch: 3643_cons_handler_min_macro
Initial changeset: [1afe2a0]

[mc-butler]

Changed by zaytsev (@zyv) on May 11, 2016 at 19:40 UTC (comment 3)

Hi Ben, thank you for the patch, and sorry for the FTBFS. Unfortunately, we don't have a FreeBSD builder, as Travis CI is Linux only, and so we've overlooked one instance of our proprietary min macro use in FreeBSD-only code during the latest refactoring round...

[mc-butler]

Changed by andrew_b (@aborodin) on May 12, 2016 at 5:22 UTC (comment 4)

• Votes set to andrew_b
• Branch state changed from on review to approved

[mc-butler]

Changed by zaytsev (@zyv) on May 12, 2016 at 5:51 UTC (comment 5)

• Resolution set to fixed
• Status changed from accepted to testing
• Votes changed from andrew_b to committed-master
• Branch state changed from approved to merged

Merged to master: [9cd1e16]

[mc-butler]

Changed by zaytsev (@zyv) on May 12, 2016 at 16:15 UTC (comment 6)

• Status changed from testing to closed