Options/Layout/Equal split gets reverted

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3718
Reporter	egmont (@egmontkob)

Open Options -> Layout, toggle Equal split.

Press Up or Shift+Tab to move the focus up to the Vertical/Horizontal radiobuttons. Equal split gets reverted to its previous value.

Or: Press the Down arrow or Tab about 10 times until the focus cycles through and enters Vertical/Horizontal radiobuttons. Again: Equal split gets reverted.

(Pressing e.g. Down and then Up properly causes the new value to stick.)

I couldn't find any other field in Options that behaves this way.

Note

Original attachments:

• 3718-Options-Layout-Equal-split-gets-reverted.patch (raw) by mooffie (@mooffie) on Nov 6, 2016 at 3:09 UTC

[mc-butler]

Changed by egmont (@egmontkob) on Nov 5, 2016 at 21:36 UTC (comment 1)

Related tickets: #3716, #3717.

[mc-butler]

Changed by mooffie (@mooffie) on Nov 6, 2016 at 2:48 UTC (comment 2)

I see that radios no longer explicitly send MSG_NOTIFY to the parent when they change. It happens "by chance": in #3721 I described how pressing a key indirectly, via MSG_CURSOR, causes the widget to re-focus... which in its turn sends MSG_NOTIFY.

@andrew:

• Why don't we go back to the happy old days when focusing a widget didn't sent MSG_NOTIFY? Or perhaps there were never such days? Whatever. Perhaps we should create MSG_NOTIFY_ON_FOCUS till the snafu is cleared up? I wasn't here when you introduced these last changes so I'm not familiar with them.

• I see that radios/buttons/chewckboxes do send_message (w->owner, w, MSG_POST_KEY, ' ', NULL) on MSG_MOUSE_CLICK. Do you happen to know what that's for?

[mc-butler]

Changed by mooffie (@mooffie) on Nov 6, 2016 at 3:09 UTC

• Attachment 3718-Options-Layout-Equal-split-gets-reverted.patch (raw) added

[mc-butler]

Changed by mooffie (@mooffie) on Nov 6, 2016 at 3:10 UTC (comment 3)

(I haven't tested the patch thoroughly.)

[mc-butler]

Changed by mooffie (@mooffie) on Nov 6, 2016 at 3:18 UTC (comment 4)

(I attached the patch just because "a patch is worth a thousand words". I'd have preferred for the MSG_NOTIFY[MSG_FOCUS] to go away.)

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 6, 2016 at 7:45 UTC (comment 2.5)

Replying to mooffie:

• Why don't we go back to the happy old days when focusing a widget didn't sent MSG_NOTIFY? Or perhaps there were never such days? Whatever. Perhaps we should create MSG_NOTIFY_ON_FOCUS till the snafu is cleared up? I wasn't here when you introduced these last changes so I'm not familiar with them.

I answered in #3716 comment 3.

• I see that radios/buttons/chewckboxes do send_message (w->owner, w, MSG_POST_KEY, ' ', NULL) on MSG_MOUSE_CLICK. Do you happen to know what that's for?

I can't say. It was left as is in the new mouse API [51d0783].

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 24, 2016 at 6:57 UTC (comment 6)

• Status changed from new to accepted
• Branch state changed from no branch to on review
• Owner set to andrew_b
• Milestone changed from Future Releases to 4.8.19

Branch: 3718_radio_notify
[e68f105]

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 24, 2016 at 6:59 UTC (comment 7)

• Votes set to andrew_b
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 24, 2016 at 7:00 UTC (comment 8)

• Votes changed from andrew_b to committed-master
• Branch state changed from approved to merged
• Status changed from accepted to testing
• Resolution set to fixed

Merged to master: [3c8e9b3].

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 24, 2016 at 7:02 UTC (comment 9)

• Status changed from testing to closed

[mc-butler]

Changed by gnusupport (bugs@….support) on Feb 2, 2017 at 8:01 UTC (comment 10)

mc --version
GNU Midnight Commander 4.8.18
Built with GLib 2.50.1
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

If I mark Equal split to [x] it is not making any equal split in this version, it cannot be reset back to equal.

[mc-butler]

Changed by zaytsev-work (@zyv) on Feb 2, 2017 at 10:55 UTC (comment 11)

Of course it doesn't, the bug is fixed in master and the fix will be released with 4.8.19.