mc_tmpdir() use a buffer on only 64 characters

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3736
Reporter	sorin (@ssbarnea)

It seems that mc_tmpdir() is using a buffer that is far too small, causing problems on some operating systems like Mac OS.

One example http://dennis.dieploegers.de/using-mc-wrapper-sh-on-a-mac/

The buffer should be increased to at least 256 characters.

[mc-butler]

Changed by sorin (@ssbarnea) on Dec 6, 2016 at 17:22 UTC (comment 1)

I created a PR that is supposed to address this issue at #119

[mc-butler]

Changed by egmont (@egmontkob) on Dec 6, 2016 at 18:33 UTC (comment 2)

I think this method should rather dynamically allocate the required space, without introducing another (higher, but still) arbitrary limit.

[mc-butler]

Changed by sorin (@ssbarnea) on Dec 6, 2016 at 18:52 UTC (comment 3)

I updated the PR to use MAX_PATH which is much better than approach, at least it will bring this to the same value that is used in many other places in mc.

[mc-butler]

Changed by egmont (@egmontkob) on Dec 6, 2016 at 20:04 UTC (comment 4)

Sounds great to me, thanks!

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 7, 2016 at 6:48 UTC (comment 5)

• Milestone changed from Future Releases to 4.8.19
• Status changed from new to accepted
• Owner set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 7, 2016 at 6:50 UTC (comment 6)

• Votes set to andrew_b
• Branch state changed from no branch to approved

Branch: 3736_mc_tmpdir
[0cf8e8f]

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 7, 2016 at 6:51 UTC (comment 7)

• Status changed from accepted to testing
• Votes changed from andrew_b to committed-master
• Resolution set to fixed
• Branch state changed from approved to merged

Merged to master: [87cc7ba].

Thanks!

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 7, 2016 at 6:52 UTC (comment 8)

• Status changed from testing to closed