extfs: tester: let test scripts easily access configure-time parameters.

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3753
Reporter	mooffie (@mooffie)

This patch introduces a mechanism by which tests can easily access configure-time parameters, like @Perl@, @awk@, etc.

(The traditional method, of *.in files, can still be used of course, but this mechanism is more comfortable.)

Rationale

As seen in #3751, tests should have access to configure-time parameters. After committing this patch, the file 'data/rpm.rewrite.sh' could be written as follows:

. "$MC_TEST_EXTFS_CONFIG_SH"

blah_blah_blah()
{
  $PERL -e 'whatever perl code'
}

Note

Original attachments:

• 3753-extfs-tester-let-test-scripts-easily-access-configure-time-parameters.patch (raw) by mooffie (@mooffie) on Jan 8, 2017 at 15:51 UTC

[mc-butler]

Changed by mooffie (@mooffie) on Jan 8, 2017 at 15:51 UTC

• Attachment 3753-extfs-tester-let-test-scripts-easily-access-configure-time-parameters.patch (raw) added

[mc-butler]

Changed by mooffie (@mooffie) on Jan 8, 2017 at 15:53 UTC

• Blocking set to #3751

[mc-butler]

Changed by zaytsev (@zyv) on Jan 12, 2017 at 20:00 UTC (comment 2)

• Milestone changed from Future Releases to 4.8.19
• Status changed from new to accepted
• Owner set to zaytsev

[mc-butler]

Changed by zaytsev (@zyv) on Jan 12, 2017 at 20:56 UTC (comment 3)

I have convened with Andrew earlier this week, and we both agree that on the basis of your contributions you should be granted commit access to the source repository (a long time ago ;-) ). Today, I have cleaned up our GitHub organization settings and sent you an invitation to join the committers team. If anything, this will save us all a lot of time posting patches to Trac & creating branches from them. What do you think?

In terms of workflows, I believe that you might have followed our conversation with Egmont on the mailing list, and I hope that this also works for you... I'd be happy to discuss whatever you think is worth being discussed and help you if you need any help, but vacation time is over, and so I will be able to make as much time than I spent in the last couple of weeks :-/

[mc-butler]

Changed by mooffie (@mooffie) on Jan 13, 2017 at 13:56 UTC (comment 3.4)

Replying to zaytsev:

I have convened with Andrew earlier this week, and we both agree that [...] sent you an invitation to join the committers team

Andrew and Yury: thank you for your vote of confidence!

What do you think?

Superb.

In terms of workflows, I believe that you might have followed our conversation with Egmont on the mailing list,

Yes.

This post (and this one) contains everything.

I already started the workflow for #3752 (which blocks this ticket). Once I merge that one I'll handle this ticket.

(I won't be here till Sunday.)

[mc-butler]

Changed by zaytsev (@zyv) on Jan 13, 2017 at 17:35 UTC (comment 5)

• Status changed from accepted to assigned
• Owner changed from zaytsev to mooffie

Awesome!

[mc-butler]

Changed by mooffie (@mooffie) on Jan 15, 2017 at 18:16 UTC (comment 6)

• Branch state changed from no branch to on review

branch: 3753_extfs_tester_access_configure_parameters
[69897e9]

[mc-butler]

Changed by zaytsev (@zyv) on Jan 15, 2017 at 18:52 UTC (comment 7)

• Votes set to zaytsev
• Branch state changed from on review to approved

[mc-butler]

Changed by mooffie (@mooffie) on Jan 15, 2017 at 19:25 UTC (comment 8)

• Votes changed from zaytsev to committed-master
• Branch state changed from approved to merged
• Status changed from assigned to testing
• Resolution set to fixed

Merged to master: [b229abc]

[mc-butler]

Changed by mooffie (@mooffie) on Jan 15, 2017 at 19:26 UTC (comment 9)

• Status changed from testing to closed

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:52 UTC

• Blocking #3751 deleted

[mc-butler]

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:53 UTC (comment 11)

• Blocked by changed from #3752 to #3730