Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emacs keymap #3755

Open
mc-butler opened this issue Jan 11, 2017 · 12 comments
Open

Fix emacs keymap #3755

mc-butler opened this issue Jan 11, 2017 · 12 comments
Assignees
Labels
area: keybind Key bindings prio: low Minor problem or easily worked around

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3755
Reporter Bad_ptr (@Bad-ptr)
Keywords keymap

It will be more consistent with emacs if the ctrl-w was mapped to cut(currently it is mapped to remove for mc dialogs).

@mc-butler
Copy link
Author

Changed by Bad_ptr (@Bad-ptr) on Jan 11, 2017 at 19:31 UTC (comment 1)

Here is an example of how it could be achieved Bad-ptr/mc@404ef82

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 11, 2017 at 21:06 UTC (comment 2)

I agree that Ctrl+W should be Cut rather than Remove in the Emacs keymap, but as far as I know Ctrl-D is "delete one character from the right", so shouldn't it rather be mapped to Delete as in the main keymap, if at all? Also, I think that Ctrl-H should be added to Backspace while we are at it.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 11, 2017 at 21:08 UTC (comment 3)

  • Owner set to zaytsev
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.19

@mc-butler
Copy link
Author

Changed by Bad_ptr (@Bad-ptr) on Jan 12, 2017 at 7:12 UTC (comment 2.4)

Replying to zaytsev:

as far as I know Ctrl-D is "delete one character from the right"

Yes, you are right. I mapped it to ctrl-d because I just don't understand how keymaps works in mc.
At first I tried to comment out the Remove = ctrl-w entry and add a Cut = ctrl-w, but it didn't help(why?), then I remapped Remove to ctrl-d and it worked. Now I realized that I can unmap Remove using Remove=.
The same thing in the [editor] section with Paste = ctrl-y and DeleteLine = ctrl-y.

shouldn't it rather be mapped to Delete

It seems like Delete is already doing deletion, however looking at the C code there is a difference between Remove and Delete, but I do not understand what is that difference.)

Also, I think that Ctrl-H should be added to Backspace while we are at it.

In emacs the C-h is for help, but I'm not against it as it will be consistent with the readline. (and looks like C-h is already doing backspace)

@mc-butler
Copy link
Author

Changed by Bad_ptr (@Bad-ptr) on Jan 13, 2017 at 15:09 UTC (comment 1.5)

Replying to Bad_ptr:
New version
Bad-ptr/mc@31a3fd0

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 18, 2017 at 17:29 UTC (comment 6)

  • Milestone changed from 4.8.20 to 4.8.21

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 27, 2018 at 13:13 UTC (comment 7)

  • Milestone changed from 4.8.21 to 4.8.22

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Dec 29, 2018 at 14:57 UTC (comment 8)

  • Milestone changed from 4.8.22 to 4.8.23

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 16, 2019 at 17:18 UTC (comment 9)

  • Milestone changed from 4.8.23 to 4.8.24

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 5, 2020 at 17:29 UTC (comment 10)

  • Milestone changed from 4.8.25 to 4.8.26

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 10, 2021 at 14:21 UTC (comment 11)

  • Milestone changed from 4.8.26 to 4.8.27

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 8, 2021 at 6:20 UTC (comment 12)

  • Milestone changed from 4.8.27 to Future Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: keybind Key bindings prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants