crash on startup (SIGSEGV) with MALLOC env variables

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3846
Reporter	narcan (debian@…-briand.fr)

Step to reproduce:

$ MALLOC_PERTURB_=254 MALLOC_CHECK_=2 mc

then during the startup: hit "Ctrl+x g" keys combo

Important: you must hit "Ctrl+x g" keys before the panels are displayed.
To reproduce this long start, the user has got 370 sub-directories in the current directory.

see https://bugs.debian.org/870728 for more details

valgrind report attached

Thank you

Denis Briand

Note

Original attachments:

• valgrind.txt (raw) by zaytsev (@zyv) on Aug 5, 2017 at 8:08 UTC
• 3846_mcview_hook.patch (raw) by andrew_b (@aborodin) on Aug 5, 2017 at 17:37 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2017 at 4:15 UTC (comment 1)

"Ctrl-x + g" is unbound by default. Do you mean "Ctrl-x + q"?

[mc-butler]

Changed by zaytsev (@zyv) on Aug 5, 2017 at 8:02 UTC (comment 2)

• Version changed from master to 4.8.18

From looking at the backtrace and valgrind report its sounds very much like #3700 to me (use after free in vfs_path_free), but with quick view panel involved now. Also, set field the version correctly.

[mc-butler]

Changed by zaytsev (@zyv) on Aug 5, 2017 at 8:08 UTC

• Attachment valgrind.txt (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2017 at 8:43 UTC (comment 3)

Perhaps, this is very much like #2657. The root of problem is action with dialog while it is being initialized. While dialog initialization is not finished, dialog should ignore or put key and/or mouse events off.

[mc-butler]

Changed by zaytsev (@zyv) on Aug 5, 2017 at 9:03 UTC (comment 4)

FYI, Denis has just confirmed

Oops its ctrl+x q of course :)

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2017 at 17:37 UTC

• Attachment 3846_mcview_hook.patch (raw) added

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2017 at 17:39 UTC (comment 5)

Please test the attached 3846_mcview_hook.patch.

[mc-butler]

Changed by zaytsev (@zyv) on Aug 6, 2017 at 20:41 UTC (comment 6)

Hi Andrew! Paul says that the patch has solved the problem for him. See the Debian ticket for the details. Many thanks!

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2017 at 7:20 UTC (comment 7)

• Status changed from new to accepted
• Version changed from 4.8.18 to master
• Component changed from mc-core to mcview
• Owner set to andrew_b
• Branch state changed from no branch to on review
• Milestone changed from Future Releases to 4.8.20

Branch: 3846_mcview_hook
[94eb32198e4064c795d4b519c2a73b9023d498ec]

[mc-butler]

Changed by zaytsev (@zyv) on Aug 7, 2017 at 10:29 UTC (comment 8)

• Votes set to zaytsev

Left a typo fix comment on github.

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2017 at 10:40 UTC (comment 9)

• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2017 at 10:41 UTC (comment 10)

• Status changed from accepted to testing
• Votes changed from zaytsev to committed-master
• Resolution set to fixed
• Branch state changed from approved to merged

Merged to master: [5d14225].

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 7, 2017 at 10:46 UTC (comment 11)

• Status changed from testing to closed