comparison between pointer and zero character constant

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3856
Reporter	egmont (@egmontkob)

gcc-7.2 caught this:

  CC       boxes.lo
boxes.c: In function ‘jobs_fill_listbox’:
boxes.c:431:22: warning: comparison between pointer and zero character constant [-Wpointer-compare]
     if (state_str[0] == '\0')
                      ^~
boxes.c:431:9: note: did you mean to dereference the pointer?
     if (state_str[0] == '\0')
         ^

It's indeed right, the code is buggy. It should be state_str[0][0].

Note

Original attachments:

• mc-3856-pointer-vs-character-constant.patch (raw) by egmont (@egmontkob) on Sep 22, 2017 at 16:06 UTC

[mc-butler]

Changed by egmont (@egmontkob) on Sep 22, 2017 at 16:06 UTC

• Attachment mc-3856-pointer-vs-character-constant.patch (raw) added

[mc-butler]

Changed by egmont (@egmontkob) on Sep 22, 2017 at 16:07 UTC (comment 1)

... or maybe like this (see attached patch)?

(I haven't tried runtime, just compiled it :))

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 22, 2017 at 16:54 UTC (comment 2)

• Blocked by set to #3780

[mc-butler]

Changed by andrew_b (@aborodin) on Sep 22, 2017 at 16:57 UTC (comment 3)

This is already fixed in 3780_cleanup: [b2bbd326e0aa77df8aa48b4a1b4fd25bbbb7a40a].

[mc-butler]

Changed by egmont (@egmontkob) on Sep 22, 2017 at 17:01 UTC (comment 4)

• Resolution set to fixed
• Status changed from new to closed

Oops, sorry then :)