Quiet single file overwrite

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3908
Reporter	andrew_b (@aborodin)

If target file exists, MC overwrites that file without confirmation.
The bug was introduced in #3149.

How to reproduce:

1. Create two files: touch a aa.
2. Stay on "aa".
3. Make sure that Options/Confirmation.../Overwrite option is checked on.
4. Press Shift-F6
5. Edit the "to:" value to "a" ("a" file exists) and press Enter.

Actual result:
The "a" file is overwritten w/o confirmation.

Expected result:
Since the "a" file exists the confirmation dialog must be shown.

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 7, 2018 at 10:13 UTC (comment 1)

• Status changed from new to accepted
• Branch state changed from no branch to on review
• Owner set to andrew_b
• Milestone changed from Future Releases to 4.8.21

Branch: 3908_confirm_overwrite
[7d73ce1]

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 15, 2018 at 8:32 UTC (comment 2)

• Branch state changed from on review to approved
• Votes set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 15, 2018 at 8:34 UTC (comment 3)

• Status changed from accepted to testing
• Branch state changed from approved to merged
• Resolution set to fixed
• Votes changed from andrew_b to committed-master

Merged to master: [a66ee73].

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 15, 2018 at 8:35 UTC (comment 4)

• Status changed from testing to closed

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 28, 2018 at 13:35 UTC (comment 5)

• Branch state changed from merged to no branch
• Resolution fixed deleted
• Status changed from closed to reopened
• Votes committed-master deleted

The bug has not been fixed completely.

Another test case:

1. Create files:

mkdir -p test1/1 test2/1
echo "1" > test1/1/file
echo "2" > test2/1/file

2. Run mc test1 test2
3. Select directory "1" and press F6.

Result: "file" file is overwritten w/o confirmation.
Expected result: since the "file" file exists the confirmation dialog must be shown.

The bug was introduced in #3149.
Bad commit is [3ba4417].

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 28, 2018 at 14:27 UTC (comment 6)

• Branch state changed from no branch to on review
• Milestone changed from 4.8.21 to 4.8.22

Branch: 3908_confirm_move_dir
[7ac669c]

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2018 at 15:56 UTC (comment 7)

• Votes set to andrew_b
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Aug 5, 2018 at 15:57 UTC (comment 8)

• Resolution set to fixed
• Branch state changed from approved to merged
• Votes changed from andrew_b to committed-master
• Status changed from reopened to closed

Merged to master: [5656ff5].

[mc-butler]

Changed by JackM (wojo.spam+mc@….com) on Nov 3, 2018 at 17:21 UTC (comment 9)

• Resolution fixed deleted
• Status changed from closed to reopened

Since this regression is critical as it may result in data loss and the flaw is still present in the last release available 4.8.21 could you please introduce the fix in a form of a release as soon as possible?

[mc-butler]

Changed by andrew_b (@aborodin) on Nov 3, 2018 at 17:37 UTC (comment 10)

• Resolution set to fixed
• Status changed from reopened to closed

What reason for reopen? Bug is fixed, isn't it?
4.8.22 to be released in November.

[mc-butler]

Changed by JackM (wojo.spam+mc@….com) on Nov 3, 2018 at 21:46 UTC (comment 11)

Apologies, yes, the regression is fixed with merged [5656ff5].

However, I was merely suggesting that in case of such important issues there should be an emergency release taking place (out of regular release cycle), so that all the distros could pick it up.