Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcedit man page talks about scanf search which seems to be removed #3918

Closed
mc-butler opened this issue Jun 1, 2018 · 8 comments
Closed
Assignees
Labels
area: docs Improvements or additions to documentation prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3918
Reporter yarda (jskarvad@….com)
Mentions jskarvad@….com, andrew_b (@aborodin)

Version:
mc-4.8.20

Reproducer:
Check doc/man/mcedit.1.in

In the section MISCELLANEOUS there is article and example introducing scanf search and replace. I think this feature has been removed in 2009 by commit [74c8c74]. Thus the manual page shuld be probably updated by removing this section. Patch attached.

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by yarda (jskarvad@….com) on Jun 1, 2018 at 14:18 UTC

Proposed fix

@mc-butler
Copy link
Author

Changed by yarda (jskarvad@….com) on Jun 1, 2018 at 14:19 UTC (comment 1)

  • Component changed from mc-core to documentation
  • Cc set to jskarvad@….com

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 2, 2018 at 5:12 UTC (comment 2)

  • Milestone changed from Future Releases to 4.8.22

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 3, 2018 at 11:16 UTC (comment 3)

  • Cc changed from jskarvad@….com to jskarvad@….com, andrew_b

Andrew, OK to commit to master?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 3, 2018 at 11:22 UTC (comment 4)

I'm working on that right now.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 3, 2018 at 11:23 UTC (comment 5)

  • Status changed from new to accepted
  • Owner set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 3, 2018 at 11:24 UTC (comment 6)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Votes set to committed-master
  • Branch state changed from no branch to merged

Applied as [0ee04e1].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 3, 2018 at 11:25 UTC (comment 7)

  • Status changed from testing to closed

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants