iso9660 does not report listing errors

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3993
Reporter	slyfox (@trofi)

This bug is a few variations of https://bugs.gentoo.org/533214.
I believe they all stem from the same underlying cause: iso9660 does not report listing errors.

Variation 1:

Steps to reproduce:

• create empty .iso file (touch foo.iso)
• run 'mc' and press enter on empty .iso

Expected result: some error about invalid file format (sililar to what F3 view would yield)
Actual result: mc elters a file as if it would be empty valid file

Variation 2:
Steps to reproduce:

• pick valid .iso file
• deinstall all helper tools that handle .sio (isoinfo, xorriso, etc.)
• run 'mc' and press enter on empty .iso

Expected result: some error about invalid file format (sililar to what F3 view would yield)
Actual result: mc enters a file as if it would be empty valid file

Variation 2 is especially confusing for users as it does not hint them that they should install a tool to get it working. They just observe silently broken behaviour.

$ LANG=C mc --version
GNU Midnight Commander 4.8.22
Built with GLib 2.58.3
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish, smbfs
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 16, 2019 at 11:22 UTC (comment 1)

diff --git a/src/vfs/extfs/helpers/iso9660.in b/src/vfs/extfs/helpers/iso9660.in
index 8c2240e8e..85716ba48 100644
--- a/src/vfs/extfs/helpers/iso9660.in
+++ b/src/vfs/extfs/helpers/iso9660.in
@@ -133,7 +133,7 @@ mcisofs_list () {
       *)     MYCAT="cat";;
     esac
 
-    $ISOINFO -l -i "$1" 2>/dev/null | @AWK@ -v SEMICOLON=$SEMICOLON '
+    $ISOINFO -l -i "$1" | @AWK@ -v SEMICOLON=$SEMICOLON '
 BEGIN {
   dir="";
   # Pattern to match 8 first fields.

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 7, 2019 at 12:51 UTC (comment 2)

• Component changed from mc-core to mc-vfs
• Milestone changed from Future Releases to 4.8.24
• Owner set to andrew_b
• Branch state changed from no branch to on review
• Status changed from new to accepted

Branch: 3993_iso9660_error_report
Initial [1ea6788c12b8f9a1151972d354bfc90c73e4b6e3]

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 20, 2019 at 16:06 UTC (comment 3)

• Branch state changed from on review to approved
• Votes set to andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 20, 2019 at 16:08 UTC (comment 4)

• Status changed from accepted to testing
• Votes changed from andrew_b to committed-master
• Resolution set to fixed

Merged to master: [27fe8f3].

git log --pretty=oneline 3a1f3d7ff..27fe8f39a

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 20, 2019 at 16:09 UTC (comment 5)

• Status changed from testing to closed