savannah: Incorrect sorting of localized filenames

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4
Reporter	slavazanko (@slavaz)

Original: http://savannah.gnu.org/bugs/?8158

Submitted by:	None	Submitted on:	Tue 16 Mar 2004 02:07:53 AM UTC
Category:	Screen output	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	4.6.0	Operating System:	GNU/Linux

Original submission:

I have a koi8-r locale and some files with russian names. When 
sorting configured as case sensitive, I can see a new russian 
alphabet at the panels :)

I look in source code and found an error - the "strcmp" function 
used for sorting all names, but it's doesn't know about any locale. 
So it should be replaced by something else. For example, "wcscmp".

Here is the patch to correct this problem. It's some big, but I 
think, it's will be work with any locales.

Note

Original attachments:

• mc-4.6.0-sort-fix.patch (raw) by slavazanko (@slavaz) on Dec 24, 2008 at 10:06 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 24, 2008 at 10:06 UTC

• Attachment mc-4.6.0-sort-fix.patch (raw) added

[mc-butler]

Changed by guanx (guanx.bac@….com) on Mar 16, 2009 at 22:34 UTC (comment 1)

• Keywords set to rework

Tested with mc-4.6.2 + utf8 patch in zh_CN.UTF-8 locale. Does not work (should sort Chinese like strcoll, but actually in random order).

[mc-butler]

Changed by styx (@styx) on Apr 20, 2009 at 9:13 UTC (comment 2)

• Milestone set to 4.7

[mc-butler]

Changed by angel_il (@ilia-maslakov) on May 20, 2009 at 9:35 UTC (comment 3)

• Status changed from new to closed
• Resolution set to fixed

in master not actually

[mc-butler]

Changed by angel_il (@ilia-maslakov) on May 20, 2009 at 9:37 UTC (comment 1.4)

Replying to guanx:

zh_CN.UTF-8 locale. Does not work (should sort Chinese).

try in master, i can't test in Chinese i don't speak/read in chinese.

[mc-butler]

Changed by ossi (@ossilator) on Jan 11, 2014 at 15:20 UTC (comment 5)

• Description edited
• Branch state set to no branch

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 12, 2014 at 7:12 UTC (comment 6)

• Keywords rework deleted