syntax highlighting for shell is broken since 4.8.24 -rc1

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4054
Reporter	wwp (subscript@….fr)
Keywords	syntaxt, highlighting, shell, mcedit

since 4.8.24-rc1 (4.8.23-149-g06bf088bc), the syntax highlighting of shell scripts in mcedit misbehaves around matches of "function blabla()" inside literal quotes. It applies syntax highlighting as if it was function definition in normal conditions (out of literal quotes), breaking the colouring of whatever follows.

The following sample shows the issue:

function foo()
{
   echo "normal color highlighting"
   echo "function bar() abnormal color highlighting"
}

[mc-butler]

Changed by wwp (subscript@….fr) on Jan 21, 2020 at 12:48 UTC (comment 1)

Apparently, the default is NOT in sh.syntax, because replacing w/ 4.8.23's one doesn't fix it. If the code for syntax highlighthing in mcedit itself is fault, then it's probably buggy for some other languages.

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 21, 2020 at 13:03 UTC (comment 2)

• Description edited
• Component changed from mc-core to mcedit

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 21, 2020 at 13:08 UTC (comment 3)

Probably, this is a result of #3981.

[mc-butler]

Changed by wwp (subscript@….fr) on Jan 21, 2020 at 13:16 UTC (comment 4)

Right, I edited my sh.syntax to revert the changes and the issue has gone. Strangely I didn't notice the issue w/ mc 4.8.23.

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 6, 2020 at 17:16 UTC (comment 5)

• Owner set to andrew_b
• Status changed from new to accepted

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 6, 2020 at 17:18 UTC (comment 6)

• Milestone changed from Future Releases to 4.8.25
• Resolution set to fixed
• Status changed from accepted to testing

Fixed as [9311136] by reverting of [91d6d55].

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 6, 2020 at 17:19 UTC (comment 7)

• Status changed from testing to closed