Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WIM archive(image) support #4100

Closed
mc-butler opened this issue Jun 26, 2020 · 15 comments
Closed

Add WIM archive(image) support #4100

mc-butler opened this issue Jun 26, 2020 · 15 comments
Assignees
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4100
Reporter MooSE (moose@….com)
Keywords wim, archive

Hi!

My small pull request: #154

It improve "view" feature by adding support for WIM files

Also it improve extfs.d by adding support for WIM files. For now it allow:

  • Add / Extract / Remove files
  • Remove sub images
  • Optimize / Verify archives
  • VIew archive(image) info

sub Images visible like subdirectories (IMAGE1, IMAGE2...)

Optimize and verify works via virtual files (like INSTALL in deb/rpm).

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 26, 2020 at 10:14 UTC (comment 1)

This patch contains some irrelevant info. Please clean it up.

@mc-butler
Copy link
Author

Changed by MooSE (moose@….com) on Jun 26, 2020 at 11:16 UTC (comment 1.2)

Replying to andrew_b:

This patch contains some irrelevant info. Please clean it up.

[Done]

:)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 26, 2020 at 11:24 UTC (comment 2.3)

Replying to MooSE:

Replying to andrew_b:

This patch contains some irrelevant info. Please clean it up.

[Done]

:)

Done what?

https://patch-diff.githubusercontent.com/raw/MidnightCommander/mc/pull/154.patch

still contains a lot of already committed code.

@mc-butler
Copy link
Author

Changed by MooSE (moose@….com) on Jun 26, 2020 at 13:04 UTC (comment 3.4)

Replying to andrew_b:

Done what?

https://patch-diff.githubusercontent.com/raw/MidnightCommander/mc/pull/154.patch

still contains a lot of already committed code.

Ohhh....

I close pull request, cleanup code and open new request:

#155

This code test on Linux and FreeBSD. And must be work on other systemes with sh, awk, wimtools.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jun 26, 2020 at 13:36 UTC (comment 5)

there was no need to create a new PR. you can clean up the history (git rebase -i) and force-push into the existing branch (the PR does automatically reflect that).

@mc-butler
Copy link
Author

Changed by MooSE (moose@….com) on Jun 26, 2020 at 14:46 UTC (comment 5.6)

Replying to ossi:

there was no need to create a new PR. you can clean up the history (git rebase -i) and force-push into the existing branch (the PR does automatically reflect that).

I'm trying force push, but PR still closed, and i don't know how i can it reopen. I'm not familiar with github and don't know what i can do for reopen.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 26, 2020 at 15:59 UTC (comment 7)

It would be great that you attach your patch here.

@mc-butler
Copy link
Author

Changed by MooSE (moose@….com) on Jun 26, 2020 at 21:08 UTC

@mc-butler
Copy link
Author

Changed by MooSE (moose@….com) on Jun 26, 2020 at 21:42 UTC (comment 8)

OK. Patch here.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jul 5, 2020 at 17:31 UTC (comment 9)

  • Milestone changed from 4.8.25 to 4.8.26

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 4, 2020 at 16:29 UTC (comment 10)

  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Status changed from new to accepted

Applied with some changes.

Branch: 4100_wim
[26d57e311ebc46218df125df4fb6d46807c49954]

Please test.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 29, 2020 at 13:58 UTC (comment 11)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 29, 2020 at 14:00 UTC (comment 12)

  • Votes changed from andrew_b to committed-master
  • Branch state changed from approved to merged

Merged to master: [7f49605].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 29, 2020 at 14:02 UTC (comment 13)

  • Status changed from accepted to testing
  • Resolution set to fixed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 29, 2020 at 14:02 UTC (comment 14)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Development

No branches or pull requests

2 participants