mcedit crashes at startup

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4124
Reporter	ossi (@ossilator)
Mentions	ericmrobertsdeveloper@….com

i have a script that wraps mcedit, which i have configured as the edit action for a certain file extension via mc.ext. somewhen recently, this stopped working - mcedit immediately crashes upon startup. i suppose this is related to the attempts to make it behave inside subshells.

#0  0x00005615432773de in widget_set_size (w=0x0, y=y@entry=39, x=<optimized out>, lines=lines@entry=1, cols=cols@entry=14)
    at widget-common.c:450
        r = {y = 39, x = 0, lines = 1, cols = 14}
#1  0x000056154325a8c8 in setup_cmdline () at layout.c:999
        mw = 0x561544e876d0
        prompt_width = 14
        y = 39
        tmp_prompt = <optimized out>
#2  0x000056154329c24b in set_prompt_string () at common.c:719
No locals.
#3  0x000056154329d4da in read_subshell_prompt () at common.c:1564
        rc = 0
        bytes = 77
        timeleft = {tv_sec = 0, tv_usec = 0}
        should_reset_prompt = 0
        got_new_prompt = 1
        tmp = {fds_bits = {0 <repeats 16 times>}}
#4  0x000056154325b375 in do_load_prompt () at layout.c:1473
No locals.
#5  0x000056154325b3f0 in load_prompt (fd=<optimized out>, unused=<optimized out>) at layout.c:1502
No locals.
#6  0x0000561543258738 in check_selects (select_set=0x7ffe2a9636a0) at key.c:618
        s = <optimized out>
        p = <optimized out>
#7  0x00005615432599cc in tty_get_event (event=event@entry=0x7ffe2a963764, redo_event=0, block=block@entry=1) at key.c:2055
        nfd = 14
        select_set = {fds_bits = {0 <repeats 16 times>}}
        c = <optimized out>
        flag = <optimized out>
        ev = {buttons = 0 '\000', modifiers = 0 '\000', vc = 0, dx = 0, dy = 0, x = 0, y = 0, type = (unknown: 0), clicks = 0,
          margin = (unknown: 0), wdx = 0, wdy = 0}
        time_out = {tv_sec = 0, tv_usec = 94649321096543}
        time_addr = <optimized out>
        dirty = 1
#8  0x000056154324be65 in frontend_dlg_run (h=0x561544e8ab00) at dialog.c:316
        d_key = <optimized out>
        wh = 0x561544e8ab00
        event = {buttons = 0 '\000', modifiers = 0 '\000', vc = 0, dx = -31107, dy = 17193, x = -1, y = 0, type = (unknown: 0),
          clicks = 0, margin = (unknown: 1156098816), wdx = 22037, wdy = 0}
#9  dlg_run (h=h@entry=0x561544e8ab00) at dialog.c:573
No locals.
#10 0x000056154329890d in edit_files (files=<optimized out>) at editwidget.c:1272
        made_directory = 1
        edit_dlg = 0x561544e8ab00
        g = 0x561544e8ab00
        menubar = <optimized out>
        w = <optimized out>
        wd = 0x561544e8ab00
        file = 0x0
        ok = 1
#11 0x00005615432608cf in mc_maybe_editor_or_viewer () at midnight.c:984
        ret = <optimized out>
#12 do_nc () at midnight.c:1827
        ret = <optimized out>
#13 0x00005615432431a1 in main (argc=<optimized out>, argv=<optimized out>) at main.c:467
        mcerror = 0x0
        config_migrated = 0
        config_migrate_msg = 0x0
        exit_code = 1

[mc-butler]

Changed by ossi (@ossilator) on Oct 9, 2020 at 9:41 UTC (comment 1)

• Description edited
• Summary changed from mcedit vs. mc.ext to mcedit crashes at startup

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 9, 2020 at 11:51 UTC (comment 2)

• Component changed from mcedit to mc-core
• Owner set to andrew_b
• Status changed from new to accepted
• Milestone changed from Future Releases to 4.8.26

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 9, 2020 at 12:00 UTC (comment 3)

• Branch state changed from no branch to on review
• Cc set to ericmrobertsdeveloper@….com

Branch: 4124_mcedit_crash
[2f61178]

Please review and test.

[mc-butler]

Changed by ossi (@ossilator) on Oct 9, 2020 at 13:19 UTC (comment 4)

• Votes set to ossi

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 10, 2020 at 12:32 UTC (comment 5)

• Branch state changed from on review to approved
• Votes changed from ossi to ossi andrew_b

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 10, 2020 at 12:34 UTC (comment 6)

• Resolution set to fixed
• Branch state changed from approved to merged
• Votes changed from ossi andrew_b to committed-master
• Status changed from accepted to testing

Merged to master: [09473d8].

[mc-butler]

Changed by andrew_b (@aborodin) on Oct 10, 2020 at 12:36 UTC (comment 7)

• Status changed from testing to closed