mcedit's 'command/Find declaration' dialogbox width is hardcoded to 64chars

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/4132
Reporter	dextarr (dextarr@….hu)
Keywords	ctag, dialog, width, autoscale

The current CTAGS implementation has a fixed width dialog box:

src/editor/etags.h line 9
#define MAX_WIDTH_DEF_DIALOG 60

Nowadays probably many of us use mc in a bigger terminal than 80x25 so it would be awesome if the dialogbox in question would scale. i have to work with some long variable/function names and ugly nested path components which get really badly truncated in that tiny space.

e.g. the actual dialogbox width could be calculated using the longest 'label_def' (src/editor/editcmd_dialogs.c:456) the listbox get filled with. In case that turns out too wide then the COL of the terminal - some chars. This would/could still also be backward compatible for the 80x25 folks).

thanks for considering!

dextarr

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 6, 2021 at 15:36 UTC (comment 1)

• Owner set to andrew_b
• Milestone changed from Future Releases to 4.8.27
• Status changed from new to accepted
• Branch state changed from no branch to on review

Branch: 4132_tags_dialog_width
Initial [46c37bf675590adbc8aeffaf0aec9c0207145460]

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 13, 2021 at 17:35 UTC (comment 2)

• Votes set to andrew_b
• Branch state changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 13, 2021 at 17:38 UTC (comment 3)

• Resolution set to fixed
• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from andrew_b to committed-master

Merged to master: [32c2802].

git log --pretty=oneline 26e568cd7..32c28026f

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 13, 2021 at 17:41 UTC (comment 4)

• Status changed from testing to closed